Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758157AbcDMOr1 (ORCPT ); Wed, 13 Apr 2016 10:47:27 -0400 Received: from mga14.intel.com ([192.55.52.115]:51830 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759180AbcDMOrY (ORCPT ); Wed, 13 Apr 2016 10:47:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,479,1455004800"; d="scan'208";a="685625402" Message-ID: <1460558891.6620.147.camel@linux.intel.com> Subject: Re: [PATCH v1 12/12] serial: 8250_lpss: enable DMA on Intel Quark UART From: Andy Shevchenko To: "Bryan O'Donoghue" , Andy Shevchenko Cc: Vinod Koul , "linux-kernel@vger.kernel.org" , dmaengine , Greg Kroah-Hartman , "Puustinen, Ismo" , Heikki Krogerus , "linux-serial@vger.kernel.org" Date: Wed, 13 Apr 2016 17:48:11 +0300 In-Reply-To: <1460558093.19152.151.camel@nexus-software.ie> References: <1460061433-63750-1-git-send-email-andriy.shevchenko@linux.intel.com> <1460061433-63750-13-git-send-email-andriy.shevchenko@linux.intel.com> <1460388795.19152.38.camel@nexus-software.ie> <1460478320.19152.92.camel@nexus-software.ie> <1460479824.6620.121.camel@linux.intel.com> <1460546565.19152.148.camel@nexus-software.ie> <1460549027.6620.131.camel@linux.intel.com> <1460558093.19152.151.camel@nexus-software.ie> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 600 Lines: 17 On Wed, 2016-04-13 at 15:34 +0100, Bryan O'Donoghue wrote: > On Wed, 2016-04-13 at 15:03 +0300, Andy Shevchenko wrote: > > > > Because a probability of FIFO overrun. > > > > There is a big chapter ("Peripheral Burst Transaction Requests") in > > dw_apb_dmac_db.pdf covering this. > I thought there was flow control between the controller and the FIFO > here ? I don't have the spec SoC spec for the UART to hand but, if > memory serves... Wait, you mean flow control between DMA controller and UART FIFO, or I misread you? -- Andy Shevchenko Intel Finland Oy