Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751644AbcDMP1U (ORCPT ); Wed, 13 Apr 2016 11:27:20 -0400 Received: from mail.efficios.com ([78.47.125.74]:47511 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbcDMP1S (ORCPT ); Wed, 13 Apr 2016 11:27:18 -0400 Date: Wed, 13 Apr 2016 15:27:15 +0000 (UTC) From: Mathieu Desnoyers To: "Richard W.M. Jones" Cc: Cyrill Gorcunov , linux-kernel@vger.kernel.org, Thomas Gleixner , mingo@redhat.com, "H. Peter Anvin" , Andrew Morton , luto@kernel.org, viro@zeniv.linux.org.uk, zab@redhat.com, emunson@akamai.com, "Paul E. McKenney" , Andrea Arcangeli , josh@joshtriplett.org, Pavel Emelyanov , sfr@canb.auug.org.au, Milosz Tanski , rostedt , arnd@arndb.de, ebiederm@xmission.com, iulia manda21 , dave hansen , mguzik@redhat.com, adobriyan@gmail.com, Davidlohr Bueso , linux-api , fw@deneb.enyo.de Message-ID: <255131446.55722.1460561235657.JavaMail.zimbra@efficios.com> In-Reply-To: <20160413135708.GG11600@redhat.com> References: <1460552272-15985-1-git-send-email-rjones@redhat.com> <1460552272-15985-2-git-send-email-rjones@redhat.com> <20160413132031.GJ2000@uranus.lan> <20160413135708.GG11600@redhat.com> Subject: Re: [PATCH v2 1/2] vfs: Define new syscall getumask. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [78.47.125.74] X-Mailer: Zimbra 8.6.0_GA_1178 (ZimbraWebClient - FF45 (Linux)/8.6.0_GA_1178) Thread-Topic: Define new syscall getumask. Thread-Index: kTJhG86++K5ftlaNGpsT6c2fReOh5Q== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2179 Lines: 54 ----- On Apr 13, 2016, at 9:57 AM, Richard W.M. Jones rjones@redhat.com wrote: > On Wed, Apr 13, 2016 at 04:20:32PM +0300, Cyrill Gorcunov wrote: >> On Wed, Apr 13, 2016 at 01:57:51PM +0100, Richard W.M. Jones wrote: >> > Define a system call for reading the current umask value. >> > >> > Signed-off-by: Richard W.M. Jones >> >> Btw don't we have to declare it in include/uapi/asm-generic/unistd.h as well? > > Yes, I think I do. I was following pwritev2 which wasn't added > to this file, but other recent system calls (mlock2, copy_file_range) > were added. > > TBH the documentation for this file is not very clear... asm-generic/unistd.h defines the system call for a few architectures. grep -r asm-generic/unistd.h arch/*/include/ arch/arc/include/uapi/asm/unistd.h:#include arch/arc/include/uapi/asm/unistd.h:/* Generic syscall (fs/filesystems.c - lost in asm-generic/unistd.h */ arch/arm64/include/uapi/asm/unistd.h:#include arch/c6x/include/uapi/asm/unistd.h:#include arch/h8300/include/uapi/asm/unistd.h:#include arch/hexagon/include/uapi/asm/unistd.h:#include arch/metag/include/uapi/asm/unistd.h:#include arch/nios2/include/uapi/asm/unistd.h:#include arch/openrisc/include/uapi/asm/unistd.h:#include arch/score/include/uapi/asm/unistd.h:#include arch/tile/include/uapi/asm/unistd.h:#include arch/unicore32/include/uapi/asm/unistd.h:#include Wiring up the system call in this header means adding support for this system call on all those architectures. Thanks, Mathieu > > Rich. > > -- > Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones > Read my programming and virtualization blog: http://rwmj.wordpress.com > virt-df lists disk usage of guests without needing to install any > software inside the virtual machine. Supports Linux and Windows. > http://people.redhat.com/~rjones/virt-df/ -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com