Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572AbcDMPn2 (ORCPT ); Wed, 13 Apr 2016 11:43:28 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:34274 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752490AbcDMPn0 (ORCPT ); Wed, 13 Apr 2016 11:43:26 -0400 MIME-Version: 1.0 In-Reply-To: <1460533238-120289-1-git-send-email-lipengcheng8@huawei.com> References: <1460533238-120289-1-git-send-email-lipengcheng8@huawei.com> Date: Wed, 13 Apr 2016 09:43:25 -0600 Message-ID: Subject: Re: [PATCH] coresight: etm4x: modify q_support type From: Mathieu Poirier To: lipengcheng Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , lizhong11@hisilicon.com, Feng Chen , liuyongfu@hisilicon.com, Dan Zhao Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1564 Lines: 38 On 13 April 2016 at 01:40, lipengcheng wrote: > Because this operation exceed the range of boolean, > so we should modify q_support to unit8 bit. > drvdata->q_support = BMVAL(etmidr0, 15, 16) > > Signed-off-by: Li Pengcheng > Signed-off-by: Li Zhong > --- > drivers/hwtracing/coresight/coresight-etm4x.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h > index a291d4c..5359c51 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.h > +++ b/drivers/hwtracing/coresight/coresight-etm4x.h > @@ -372,6 +372,7 @@ struct etmv4_drvdata { > u8 ccitmin; > u8 s_ex_level; > u8 ns_ex_level; > + u8 q_support; > bool sticky_enable; > bool boot_enable; > bool os_unlock; > @@ -380,7 +381,6 @@ struct etmv4_drvdata { > bool trccond; > bool retstack; > bool trccci; > - bool q_support; > bool trc_error; > bool syncpr; > bool stallctl; Applied - thanks. Mathieu > -- > 1.8.3.2 >