Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753490AbcDMP7e (ORCPT ); Wed, 13 Apr 2016 11:59:34 -0400 Received: from foss.arm.com ([217.140.101.70]:35837 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753099AbcDMP7c (ORCPT ); Wed, 13 Apr 2016 11:59:32 -0400 Date: Wed, 13 Apr 2016 16:59:23 +0100 From: Steve Capper To: David Daney Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , Grant Likely , Pawel Moll , Ian Campbell , Kumar Gala , Ganapatrao Kulkarni , Robert Richter , Ard Biesheuvel , Matt Fleming , Mark Rutland , Catalin Marinas , devicetree@vger.kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, David Daney Subject: Re: [PATCH v16 6/6] arm64, mm, numa: Add NUMA balancing support for arm64. Message-ID: <20160413155922.GA2144@e103986-lin> References: <1460155828-8690-1-git-send-email-ddaney.cavm@gmail.com> <1460155828-8690-7-git-send-email-ddaney.cavm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460155828-8690-7-git-send-email-ddaney.cavm@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2320 Lines: 71 On Fri, Apr 08, 2016 at 03:50:28PM -0700, David Daney wrote: > From: Ganapatrao Kulkarni > > Enable NUMA balancing for arm64 platforms. > Add pte, pmd protnone helpers for use by automatic NUMA balancing. > > Reviewed-by: Robert Richter > Signed-off-by: Ganapatrao Kulkarni > Signed-off-by: David Daney > --- > arch/arm64/Kconfig | 1 + > arch/arm64/include/asm/pgtable.h | 15 +++++++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 99f9b55..a578080 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -11,6 +11,7 @@ config ARM64 > select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST > select ARCH_USE_CMPXCHG_LOCKREF > select ARCH_SUPPORTS_ATOMIC_RMW > + select ARCH_SUPPORTS_NUMA_BALANCING > select ARCH_WANT_OPTIONAL_GPIOLIB > select ARCH_WANT_COMPAT_IPC_PARSE_VERSION > select ARCH_WANT_FRAME_POINTERS > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 989fef1..89b8f20 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -272,6 +272,21 @@ static inline pgprot_t mk_sect_prot(pgprot_t prot) > return __pgprot(pgprot_val(prot) & ~PTE_TABLE_BIT); > } > > +#ifdef CONFIG_NUMA_BALANCING > +/* > + * See the comment in include/asm-generic/pgtable.h > + */ > +static inline int pte_protnone(pte_t pte) > +{ > + return (pte_val(pte) & (PTE_VALID | PTE_PROT_NONE)) == PTE_PROT_NONE; > +} > + > +static inline int pmd_protnone(pmd_t pmd) > +{ > + return pte_protnone(pmd_pte(pmd)); > +} > +#endif > + Okay, this looks good to me. If we have a PROT_NONE VMA then this is caught before going into do_numa_page or do_huge_pmd_numa_page (and there is a BUG_ON inside these functions to catch stragglers. I've given this a quick test with a PROT_NONE THP and everything worked as expected (i.e. NUMA didn't trip up). Reviewed-by: Steve Capper > /* > * THP definitions. > */ > -- > 1.8.3.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >