Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751362AbcDMQyJ (ORCPT ); Wed, 13 Apr 2016 12:54:09 -0400 Received: from mga14.intel.com ([192.55.52.115]:62355 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbcDMQyH (ORCPT ); Wed, 13 Apr 2016 12:54:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,480,1455004800"; d="scan'208";a="944423937" Message-ID: <570E7B37.1030706@intel.com> Date: Wed, 13 Apr 2016 20:00:39 +0300 From: Mathias Nyman User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Peter Griffin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org CC: lee.jones@linaro.org, balbi@kernel.org, linux-usb@vger.kernel.org, maxime.coquelin@st.com, patrice.chotard@st.com, stable@vger.kernel.org, gregory.clement@free-electrons.com, yoshihiro.shimoda.uh@renesas.com Subject: Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value References: <1458917188-28452-1-git-send-email-peter.griffin@linaro.org> <20160411154436.GA14580@griffinp-ThinkPad-X1-Carbon-2nd> In-Reply-To: <20160411154436.GA14580@griffinp-ThinkPad-X1-Carbon-2nd> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 24 On 11.04.2016 18:44, Peter Griffin wrote: > Hi Mathias, > > On Fri, 25 Mar 2016, Peter Griffin wrote: > >> Otherwise generic-xhci and xhci-platform which have no data get wrongly >> detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is(). >> >> This fixes a regression in v4.5 for STiH407 family SoC's which use the >> synopsis dwc3 IP, whereby the disable_clk error path gets taken due to >> wrongly being detected as XHCI_PLAT_TYPE_MARVELL_ARMADA and the hcd never >> gets added. >> >> I suspect this will also fix other dwc3 DT platforms such as Exynos, >> although I've only tested on STih410 SoC. >> >> Fixes: 4efb2f694114 ("usb: host: xhci-plat: add struct xhci_plat_priv") > > Can you take this 1 charcter fix for the next -rc? > added to my tree and sent forward to Greg -Mathias