Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752552AbcDMRLe (ORCPT ); Wed, 13 Apr 2016 13:11:34 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:37992 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbcDMRLd (ORCPT ); Wed, 13 Apr 2016 13:11:33 -0400 Date: Wed, 13 Apr 2016 11:11:27 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH v3] tpm: fix crash in tpm_tis deinitialization Message-ID: <20160413171127.GB28411@obsidianresearch.com> References: <1460532126-14435-1-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460532126-14435-1-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1167 Lines: 30 On Wed, Apr 13, 2016 at 10:22:06AM +0300, Jarkko Sakkinen wrote: > rmmod crashes the driver because tpm_chip_unregister() already sets ops > to NULL. This commit fixes the issue by moving tpm2_shutdown() to > tpm_chip_unregister(). This commit is also cleanup because it removes > duplicate code from tpm_crb and tpm_tis to the core. > > v2: make sending shutdown command atomic with nulling ops > v3: forgot to amend updates, sorry :( > Signed-off-by: Jarkko Sakkinen > Fixes: 4d3eac5e156a ("tpm: Provide strong locking for device > removal") You patch got a little mangled.. The v2/v3 should be after the diffstat, not in the commit message and the --- after the SOB section is missing.. Otherwise it looks fine Reviewed-by: Jason Gunthorpe > extern int tpm2_startup(struct tpm_chip *chip, u16 startup_type); > -extern void tpm2_shutdown(struct tpm_chip *chip, u16 shutdown_type); > +void tpm2_shutdown(struct tpm_chip *chip, u16 shutdown_type); Drop this hunk though, doesn't do anything. If you don't like the unnecessary externs on functions then get rid of them all in a patch. Jason