Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819AbcDMRUM (ORCPT ); Wed, 13 Apr 2016 13:20:12 -0400 Received: from mga03.intel.com ([134.134.136.65]:21224 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbcDMRUK (ORCPT ); Wed, 13 Apr 2016 13:20:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,480,1455004800"; d="scan'208";a="957931739" Date: Wed, 13 Apr 2016 11:19:33 -0600 From: Ross Zwisler To: Dan Williams Cc: Toshi Kani , Ross Zwisler , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32 Message-ID: <20160413171933.GA24879@linux.intel.com> References: <1460506252-8596-1-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 891 Lines: 23 On Tue, Apr 12, 2016 at 10:24:25PM -0700, Dan Williams wrote: > On Tue, Apr 12, 2016 at 5:10 PM, Toshi Kani wrote: > > After 'commit fc0c2028135c ("x86, pmem: use memcpy_mcsafe() > > for memcpy_from_pmem()")', probing a PMEM device hits the BUG() > > error below on X86_32 kernel. > > > > kernel BUG at include/linux/pmem.h:48! > > > > memcpy_from_pmem() calls arch_memcpy_from_pmem(), which is > > unimplemented since CONFIG_ARCH_HAS_PMEM_API is undefined on > > X86_32. > > > > Fix the BUG() error by adding default_memcpy_from_pmem(). > > > > Signed-off-by: Toshi Kani > > Cc: Dan Williams > > Cc: Ross Zwisler > > Whoops, I'll add a 32-bit boot test to my release criteria. Thanks Toshi! Yep, this patch looks correct to me. Reviewed-by: Ross Zwisler