Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754548AbcDMRra (ORCPT ); Wed, 13 Apr 2016 13:47:30 -0400 Received: from mail-bn1on0117.outbound.protection.outlook.com ([157.56.110.117]:23966 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751256AbcDMRr2 (ORCPT ); Wed, 13 Apr 2016 13:47:28 -0400 Authentication-Results: linux.com; dkim=none (message not signed) header.d=none;linux.com; dmarc=none action=none header.from=hpe.com; Message-ID: <570E8620.60508@hpe.com> Date: Wed, 13 Apr 2016 13:47:12 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Christoph Lameter CC: Alexander Viro , Jan Kara , Jeff Layton , "J. Bruce Fields" , Tejun Heo , , , Ingo Molnar , Peter Zijlstra , Andi Kleen , Dave Chinner , Boqun Feng , Scott J Norton , Douglas Hatch Subject: Re: [PATCH v7 1/4] lib/percpu-list: Per-cpu list with associated per-cpu locks References: <1460501686-37096-1-git-send-email-Waiman.Long@hpe.com> <1460501686-37096-2-git-send-email-Waiman.Long@hpe.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.105] X-ClientProxiedBy: CY1PR13CA0024.namprd13.prod.outlook.com (10.162.30.162) To AT5PR84MB0308.NAMPRD84.PROD.OUTLOOK.COM (10.162.138.30) X-MS-Office365-Filtering-Correlation-Id: da2cd8ff-c370-4909-a6ef-08d363c3ac49 X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0308;2:wtdqKnbcLVeyi0fzBeqfVpRDvXX8FnCBYMYz2djB7fmhODDYBwCEbIl3YUBbMZ16IfBdh/ErN1AcQAjXgkSV/qc4PPds9BYCO3KJMXX95WUpyhJH0agFmLWYCpcLT37qUo71KLK9dafxzM1GS/SSVcJYYW17dHBcgJiBYnZS5qIYwWk7qBbZNVRgNXxmOMNT;3:bn2itaJW6SD59wJ3q34h6WOQTFTt9jzC2UHfIQrUZBoEGflY/SidXmsIL9tqDHxfDJUPeV2XN50UKIcG0lCujFDUmFttCRp5+0hixdioi++2GXhTSkIKDXAfk/lL6TOq X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0308; X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0308;25:0hBpNcv6AIxQLYTltydjUOMNAwsuSlHxUjmE6Tpb6CAPTXTfraOTJb0zG4tUwznofnjBQRkxLqTR5V8vt3AMiyoB0+iyj/JtviCoAc44LylvPT4fh7ei54qhfOcgI05QhhpDfYTAXaFLa1ygnCcFWA6SmtDzRAWdFxgPRvh8zHMHPZ0sAyRukS4mMIPmfGmX3JcyP4m8xdzNEC5FvQg9ShTYRp0PA9xXx6dsoUU4ZrDpngJZ0sMmX034wleXiZh/fqy2HX3cUO7NAorQFCWoIfnoROqrQEv/t49dQ8eHj+DnonW0q9T5jG31baFPeNjXi2jc/K/y+4LO03qf5drcK7y9vaR+hPsKnoEr5cmZmkhrblBekla0lxxRD5XrPwJrfuHaNpUmBVGUdiFjjcg0bvaRcTe1kjITOvSaDPirfMu9e5C4u0h15M4PdY56bwpALJNwPAQHma51ve2BFtdgk3aex3bxR+yPyAhq9h76et5QjOAlWOE7GZFO2hQKGRa93iuGywVpLSwdTZmAJmXCCRGfGOA/hOk/51q5mIWDtSZ+Jhi69XCbl+AiuEc24AHUwdCyONeRwOa2ktVUNGDMpQD9AhVMin+ApPbqEmn9Bw73gfci5Uc+o60faObA7bGUE32jwIO1TkaJaNrXzPh9xQ== X-LD-Processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0308;20:cjS8WXvZog//xIdulPsShJ3c/x+8Q3YbNv4HJDQBzXPFtHTT/7I+XXE4W9FSHC3CmNzeKRszoHZvAGlgqWa0p9U7fR95zWlrzq/S/7dCqlRRsmJi432H73Lq9brXreFQob4cdfCM4qgX/mr/SX1TTcqhsw8xrcjQk8OG+rMLi1jKLv6V7Pmz5SeRriKuHmA1lbBr2EX1/sbwY/Jw0DrJOvwWCmMyKJZjXk82FlFEtiDuILsJq9LP8rOkK7DMy7ZabSfvRk3bI/GcSQ12RLff5pNZQz50jgVHu6f8Nfw0O9HRyyshEdVBxflq8p5Ack0LpnJouCPL/+L1qZWi6XIHCA==;4:cYn6lieHUKYbPF8dr9kSwueCOFf0oW5lpKtNX0cQ2C2RxRVjSzvd14/YFIbjOSS05gvyBr+viE+Lo66Zz16U58+d7ynVnvfjkd2Z6GG9BdLvkFxxM0gxGW6Wb/VlzqOcpprTthLSBEDypa5hiY+mIjOLc0JdIrLYAmVqaMGBIkF5H/fa7MFPBE5a3w4iesykKoKt90VMwarouWsz25a9+sFGiTg3/4aR2U1kKIMuKSLzB8rKWgzHTXBF9mg7z5MJEzplC1BXdpJYwoFlKKQtOh6QL7CeLeGuKc+OOW7+TuBMpZCtbTu2dsKWXQL85uPu3gD8WObhF93qinwJCo+L8a8deBnGz6mq2AkOrzVRtSRCIPo7CC3kXBtQh2P4robB X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:AT5PR84MB0308;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0308; X-Forefront-PRVS: 0911D5CE78 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(377454003)(24454002)(86362001)(110136002)(117156001)(4001350100001)(36756003)(81166005)(42186005)(2906002)(33656002)(189998001)(2950100001)(65816999)(50986999)(586003)(76176999)(3846002)(54356999)(4326007)(65806001)(230700001)(5004730100002)(66066001)(6116002)(23756003)(50466002)(92566002)(77096005)(64126003)(5008740100001)(47776003)(1096002)(83506001);DIR:OUT;SFP:1102;SCL:1;SRVR:AT5PR84MB0308;H:[192.168.142.156];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;AT5PR84MB0308;23:XJOUI9NhQ2RwJDblAl0anYFVYbcNgv/5E0gTxMn?= =?iso-8859-1?Q?dXYoW47qe/IRTzxIg2sT5LurRhiE+0QX3YOZhCNHTqenc3w3xQbpiE1+d2?= =?iso-8859-1?Q?pw1zWd0wPupQaPLuIJS03OZ/kIKc8b0ubUJn0s4DwrQ5wMe6pxHTRcEnGm?= =?iso-8859-1?Q?3PjN2RJvYcZmPGU81yh9SItI9GakcJ1qgXOZu+AalBhiJQbUQY4SAPrZzd?= =?iso-8859-1?Q?zT0Pm0ckXaMFFGXKLhm+vbuVdzYKJOWgi1Te86upHnYnGDmoJr0+EmPQwZ?= =?iso-8859-1?Q?Ugscj+nupFV38HZNYDpz3oAlhLUDAGCPCOSoLXDS8gTaa1h7uz43QMgSM9?= =?iso-8859-1?Q?bVSFfqcKyg27aNxmZwTvOCFtycc4E6Ki/qSo53f+5ag1MshNTslXe2jB1w?= =?iso-8859-1?Q?GT23fMEbA6t/SxFc3gBwprzViNtBDFxWz0dy50m6SRcboyXOuxD+gnvF3k?= =?iso-8859-1?Q?gW60alnWiorcs3CIN4sCaoSvemN9FQsza4FbC6h+cvtdrhceltiXMPPNqM?= =?iso-8859-1?Q?0y1eIPFrUgBuf7r6pr8y2wTbO7GzLyBiGT5aMTodlxInuDYdY+SkNP7d+G?= =?iso-8859-1?Q?CHbA5P8qOoQA1Dpkvy1Be2uHuU8iOzZJgXCUECRWbNrsRPErQgiqP4iiFT?= =?iso-8859-1?Q?vgyo9xrPyzun2AxogJFGsNugvp7gMMd2/2V0OLJgENbEhAu/2CVD69AOam?= =?iso-8859-1?Q?3jX02LM/3VEeVQmKc3pgr9Ojuh8gLZsdntASe/R4ZHQpsc/Iq358g2YVja?= =?iso-8859-1?Q?YYErQJL4mf1Bl+7tT6CwJC79HslFtusHy1tjNwyqF7yF18thAcLfK6rNb6?= =?iso-8859-1?Q?Jg3Om3uKT9gLI5QUaCXiPHSWE9MKoLhgJbG+50ntoGLG//7jZnv6Hd1Aix?= =?iso-8859-1?Q?8dYCE408Cojrxiw5og1LcRE+P6LprciNc6IewpWKkgkcEqG5rQS76zE3+d?= =?iso-8859-1?Q?ZC8GJwoCHHSg3KwO4YyzUEbKcE/csB9V2PRAB78QwEG0NDr8xkzSOIGRJO?= =?iso-8859-1?Q?k0deWfwZO4Us8aZ2BKjVl7FFnQyFOYMzwS0A=3D?= X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0308;5:ULmbIiaWUELBLktw+L5AbfPUuyPYilfdOBd54u87U1vZuhqyXcWQxvYBq62qmhpjLHle/PD57OGOo0dSBlQlLmejs8FuGqXObDiBOpdy+590soG0i4C3YPioEeVy8cKRkA5reFpZ8snscLTLWKSm1g==;24:hMffsqD8mGE8FllhRm7rJjGSk+/f/dDSgABBcfzQYLfV5zedXZF7l/Y9EWwBBq56aaHFcRgKBzPlCDQ7/hVNvY4oUBbfXS4NO0kMS3v5XCo= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2016 17:47:22.8714 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0308 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 859 Lines: 20 On 04/13/2016 11:03 AM, Christoph Lameter wrote: > On Tue, 12 Apr 2016, Waiman Long wrote: > >> List entry insertion is strictly per cpu. List deletion, however, can >> happen in a cpu other than the one that did the insertion. So we still >> need lock to protect the list. Because of that, there may still be >> a small amount of contention when deletion is being done. > Ok then the list is not per cpu anymore. Can we call this something else > please to avoid confusion? Spinlocks in per cpu structures are a bit > confusing otherwise. Seems that there is no requirement that the list can > only be accessed from a single cpu so its not per cpu per se anymore. > > Maybe lock-list instead of percpu-list? > I am fine with a name change. I am not that good in naming stuff. How about distributed and locked list, or dlock_list in short? Cheers, Longman