Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751937AbcDMUHP (ORCPT ); Wed, 13 Apr 2016 16:07:15 -0400 Received: from vern.gendns.com ([206.190.152.46]:59620 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbcDMUHM (ORCPT ); Wed, 13 Apr 2016 16:07:12 -0400 Subject: Re: [PATCH v3 09/16] phy: da8xx-usb: new driver for DA8xx SoC USB PHY To: Kishon Vijay Abraham I References: <1458863503-31121-1-git-send-email-david@lechnology.com> <1458863503-31121-10-git-send-email-david@lechnology.com> <570E4796.7070005@ti.com> Cc: petr@barix.com, sergei.shtylyov@cogentembedded.com, David.Laight@ACULAB.COM, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Sekhar Nori , Kevin Hilman , Greg Kroah-Hartman , Alan Stern , Bin Liu , Lee Jones , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "moderated list:ARM PORT" , "open list:USB SUBSYSTEM" From: David Lechner Message-ID: <570EA6EC.1040001@lechnology.com> Date: Wed, 13 Apr 2016 15:07:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <570E4796.7070005@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 366 Lines: 13 On 04/13/2016 08:20 AM, Kishon Vijay Abraham I wrote: > > Don't prefer export symbols from PHY driver. That'll create unnecessary > dependencies between the controller and the PHY. > > To see how to fix it, please see my comment for the previous version of your patch. > > Thanks > Kishon > What is the proper way to give you credit for the changes you suggested?