Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751733AbcDMUKi (ORCPT ); Wed, 13 Apr 2016 16:10:38 -0400 Received: from canardo.mork.no ([148.122.252.1]:36652 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbcDMUKf convert rfc822-to-8bit (ORCPT ); Wed, 13 Apr 2016 16:10:35 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Timur Tabi Cc: Shanker Donthineni , kbuild test robot , kbuild-all@01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sdharia@codeaurora.org, Greg Kroah-Hartman , vikrams@codeaurora.org, cov@codeaurora.org, gavidov@codeaurora.org, Rob Herring , andrew@lunn.ch, bjorn.andersson@linaro.org, Mark Langsdorf , Jon Masters , Andy Gross , "David S. Miller" Subject: Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver Organization: m References: <201604140340.wQZLwsUk%fengguang.wu@intel.com> <570E9E8D.50007@codeaurora.org> <570EA09F.1070000@codeaurora.org> <570EA434.30007@codeaurora.org> Date: Wed, 13 Apr 2016 22:07:46 +0200 In-Reply-To: <570EA434.30007@codeaurora.org> (Timur Tabi's message of "Wed, 13 Apr 2016 14:55:32 -0500") Message-ID: <87ega9gtm5.fsf@nemi.mork.no> User-Agent: Gnus/5.130015 (Ma Gnus v0.15) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 27 Timur Tabi writes: > Shanker Donthineni wrote: >>>> >> drivers/net/ethernet/qualcomm/emac/emac-mac.c: In function 'emac_mac_up': >>>>>>>> >>>> >>drivers/net/ethernet/qualcomm/emac/emac-mac.c:1076:9: warning: large integer implicitly truncated to unsigned type [-Woverflow] >>>> >> writel(~DIS_INT, adpt->base + EMAC_INT_STATUS); >>> > >>> >This doesn't happen on arm64, and I don't know how to fix it. DIS_INT is defined as: >>> > >>> > #define DIS_INT BIT(31) >>> > >> Try with (1U<<31). >> > > Except that Gilad was previously asked to use the BIT() macros: > > https://lkml.org/lkml/2015/12/15/797 So typecast it. writel((u32)~DIS_INT, adpt->base + EMAC_INT_STATUS); I believe the reason you don't see this on arm64 is that the writel macro includes the typecast there. But it doesn't on x86_64 Bjørn