Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753426AbcDMUxU (ORCPT ); Wed, 13 Apr 2016 16:53:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39421 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753361AbcDMUxT (ORCPT ); Wed, 13 Apr 2016 16:53:19 -0400 Date: Wed, 13 Apr 2016 21:53:15 +0100 From: "Richard W.M. Jones" To: Florian Weimer Cc: "H. Peter Anvin" , linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org, luto@kernel.org, viro@zeniv.linux.org.uk, mathieu.desnoyers@efficios.com, zab@redhat.com, paulmck@linux.vnet.ibm.com, aarcange@redhat.com, josh@joshtriplett.org, xemul@parallels.com, sfr@canb.auug.org.au, milosz@adfin.com, rostedt@goodmis.org, arnd@arndb.de, ebiederm@xmission.com, gorcunov@openvz.org, iulia.manda21@gmail.com, dave.hansen@linux.intel.com, mguzik@redhat.com, adobriyan@gmail.com, dave@stgolabs.net, linux-api@vger.kernel.org, gorcunov@gmail.com, walters@verbum.org Subject: Re: [PATCH v4 0/3] vfs: Define new syscall umask2 [formerly getumask] Message-ID: <20160413205315.GM11600@redhat.com> References: <1460574336-18930-1-git-send-email-rjones@redhat.com> <570EA006.5010608@zytor.com> <87shypck6m.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87shypck6m.fsf@mid.deneb.enyo.de> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 931 Lines: 25 On Wed, Apr 13, 2016 at 10:45:05PM +0200, Florian Weimer wrote: > * H. Peter Anvin: > > > I have to say I'm skeptic to the need for umask2() as opposed to > > getumask(). > > I find the extension with a set-the-thread umask somewhat unlikely. > How would a potential per-thread umask interact with CLONE_FS? > Have a per-thread umask that, when active, overrides the global > one, similar to what uselocale provides? That seems rather messy, > and I'm not aware of any precedent. The flags parameter is for extensions we can't envisage now ... ... although since umask has been around since Unix V6 in 1978, we might be waiting a long time. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org