Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754835AbcDMXIc (ORCPT ); Wed, 13 Apr 2016 19:08:32 -0400 Received: from mail.kernel.org ([198.145.29.136]:34665 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbcDMXIa (ORCPT ); Wed, 13 Apr 2016 19:08:30 -0400 MIME-Version: 1.0 In-Reply-To: <57062B90.10401@citrix.com> References: <1459987594-5434-1-git-send-email-mcgrof@kernel.org> <1459987594-5434-5-git-send-email-mcgrof@kernel.org> <57062B90.10401@citrix.com> From: "Luis R. Rodriguez" Date: Wed, 13 Apr 2016 16:08:06 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk To: David Vrabel , Ingo Molnar Cc: Borislav Petkov , "H. Peter Anvin" , Thomas Gleixner , Rusty Russell , "xen-devel@lists.xensource.com" , Matt Fleming , Andrew Cooper , X86 ML , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Joey Lee , lguest@lists.ozlabs.org, Gary Lin , Boris Ostrovsky , Andy Shevchenko Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 26 On Thu, Apr 7, 2016 at 2:42 AM, David Vrabel wrote: > On 07/04/16 01:06, Luis R. Rodriguez wrote: >> We have 4 types of x86 platforms that disable RTC: >> >> * Intel MID >> * Lguest - uses paravirt >> * Xen dom-U - uses paravirt >> * x86 on legacy systems annotated with an ACPI legacy flag >> >> We can consolidate all of these into a platform specific legacy >> quirk set early in boot through i386_start_kernel() and through >> x86_64_start_reservations(). This deals with the RTC quirks which >> we can rely on through the hardware subarch, the ACPI check can >> be dealt with separately. > > Xen parts: > > Reviewed-by: David Vrabel So for instance, I dropped this Reviewed-by given that after this someone pointed out dom0 as an issue and then I addressed that. Hope to get a Reviewed-by or Acked-by for v6 then, which will also have the added __init on xen_dom0_set_legacy_features() as requested by Juergen. Luis