Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753496AbcDNCWn (ORCPT ); Wed, 13 Apr 2016 22:22:43 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:33334 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985AbcDNCWl (ORCPT ); Wed, 13 Apr 2016 22:22:41 -0400 Date: Wed, 13 Apr 2016 22:22:38 -0400 (EDT) Message-Id: <20160413.222238.1174020501502372148.davem@davemloft.net> To: blogic@openwrt.org Cc: nbd@openwrt.org, matthias.bgg@gmail.com, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net-next: mediatek: add support for IRQ grouping From: David Miller In-Reply-To: <1460053499-53659-1-git-send-email-blogic@openwrt.org> References: <1460053499-53659-1-git-send-email-blogic@openwrt.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Apr 2016 19:22:40 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 14 From: John Crispin Date: Thu, 7 Apr 2016 20:24:59 +0200 > The ethernet core has 3 IRQs. Using the IRQ grouping registers we are able > to separate TX and RX IRQs, which allows us to service them on separate > cores. This patch splits the IRQ handler into 2 separate functions, one > for TX and another for RX. The TX housekeeping is split out of the NAPI > handler. Instead we use a tasklet to handle housekeeping. > > Signed-off-by: John Crispin Don't do this with tasklets. Do your TX reclaim in a NAPI poll just like the RX side.