Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753161AbcDNDKP (ORCPT ); Wed, 13 Apr 2016 23:10:15 -0400 Received: from m50-133.163.com ([123.125.50.133]:50594 "EHLO m50-133.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752980AbcDNDKM (ORCPT ); Wed, 13 Apr 2016 23:10:12 -0400 From: zengzhaoxiu@163.com To: linux-kernel@vger.kernel.org Cc: Zhaoxiu Zeng , Dmitry Torokhov , linux-input@vger.kernel.org Subject: [PATCH V3 15/29] input: use parity32 in grip_mp Date: Thu, 14 Apr 2016 11:10:03 +0800 Message-Id: <1460603405-5220-1-git-send-email-zengzhaoxiu@163.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1460601525-3822-1-git-send-email-zengzhaoxiu@163.com> References: <1460601525-3822-1-git-send-email-zengzhaoxiu@163.com> X-CM-TRANSID: DdGowAC3RpMOCg9Xw9mhAw--.32594S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtr4fZr18urWxZFy5WF43Awb_yoWkWrc_Ca y5Z3WkWF4qqr1qkrs8Jay7Z34qya97u3929Fs7ta13J3WUWrs7G34kGrZ0yw4Fqrs5ZFW7 WwsxWryxAw4I9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU50g4DUUUUU== X-Originating-IP: [112.95.225.98] X-CM-SenderInfo: p2hqw6xkdr5xrx6rljoofrz/xtbBDRJLgFaDmYPV-gAAsw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1153 Lines: 44 From: Zhaoxiu Zeng Signed-off-by: Zhaoxiu Zeng --- drivers/input/joystick/grip_mp.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/input/joystick/grip_mp.c b/drivers/input/joystick/grip_mp.c index 573191d..3e29eb1 100644 --- a/drivers/input/joystick/grip_mp.c +++ b/drivers/input/joystick/grip_mp.c @@ -112,20 +112,6 @@ static const int axis_map[] = { 5, 9, 1, 5, 6, 10, 2, 6, 4, 8, 0, 4, 5, 9, 1, 5 static int register_slot(int i, struct grip_mp *grip); /* - * Returns whether an odd or even number of bits are on in pkt. - */ - -static int bit_parity(u32 pkt) -{ - int x = pkt ^ (pkt >> 16); - x ^= x >> 8; - x ^= x >> 4; - x ^= x >> 2; - x ^= x >> 1; - return x & 1; -} - -/* * Poll gameport; return true if all bits set in 'onbits' are on and * all bits set in 'offbits' are off. */ @@ -235,7 +221,7 @@ static int mp_io(struct gameport* gameport, int sendflags, int sendcode, u32 *pa pkt = (pkt >> 2) | 0xf0000000; } - if (bit_parity(pkt) == 1) + if (parity32(pkt)) return IO_RESET; /* Acknowledge packet receipt */ -- 2.5.0