Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752367AbcDNDYc (ORCPT ); Wed, 13 Apr 2016 23:24:32 -0400 Received: from szxga05-in.huawei.com ([58.251.152.179]:37850 "EHLO szxga05-in.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750801AbcDNDYa (ORCPT ); Wed, 13 Apr 2016 23:24:30 -0400 Subject: Re: [PATCH 10/25] arm64: rename COMPAT to AARCH32_EL0 in Kconfig To: Yury Norov , , , , References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <1459894127-17698-11-git-send-email-ynorov@caviumnetworks.com> CC: , , , , , , , , , , , , , , Andrew Pinski , Andrew Pinski , Philipp Tomsich , Hanjun Guo , "Zhangjian (Bamvor)" From: "Zhangjian (Bamvor)" Message-ID: <570F0C7D.8000004@huawei.com> Date: Thu, 14 Apr 2016 11:20:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1459894127-17698-11-git-send-email-ynorov@caviumnetworks.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.72.170] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.570F0C97.0097,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 756a277a6183ab74ca581e3d53829dc3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2464 Lines: 70 Hi, yury I suggest we enable AARCH32_EL0 by default explicitly. I am not sure if it should be a dedicated commit. I am ok if you merge my commit, add Reviewed-by: Bamvor Jian Zhang commit 926ad48847c9fbc665285c49ff823666e145a083 Author: Bamvor Jian Zhang Date: Wed Apr 6 17:59:03 2016 +0800 arm64: enable aarch32 application by default After introduce the AARCH32_EL0. The aarch32 application is disabled by default which was enabled by default. And the aarch32 application could not run on these kernels consequently. This commit enable it in Kconfig explicitly. Signed-off-by: Bamvor Jian Zhang diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 19d8e31..3b543c7 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -934,6 +934,7 @@ config AARCH32_EL0 select HAVE_UID16 select OLD_SIGSUSPEND3 select COMPAT_OLD_SIGACTION + default y help This option enables support for a 32-bit EL0 running under a 64-bit kernel at EL1. AArch32-specific components such as system calls, On 2016/4/6 6:08, Yury Norov wrote: > From: Andrew Pinski > > In this patchset ILP32 ABI support is added. Additionally to AARCH32, > which is binary-compatible with ARM, ILP32 is (mostly) ABI-compatible. > > From now, AARCH32_EL0 (former COMPAT) config option means the support of > AARCH32 userspace, ARM64_ILP32 - support of ILP32 ABI (see next patches), > and COMPAT indicates that one of them, or both, is enabled. > > Signed-off-by: Andrew Pinski > Signed-off-by: Philipp Tomsich > Signed-off-by: Christoph Muellner > Signed-off-by: Yury Norov > Reviewed-by: David Daney > --- > arch/arm64/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 4f43622..f923687 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -925,6 +925,10 @@ menu "Userspace binary formats" > source "fs/Kconfig.binfmt" > > config COMPAT > + def_bool y > + depends on AARCH32_EL0 > + > +config AARCH32_EL0 > bool "Kernel support for 32-bit EL0" > depends on ARM64_4K_PAGES || EXPERT > select COMPAT_BINFMT_ELF >