Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752615AbcDND10 (ORCPT ); Wed, 13 Apr 2016 23:27:26 -0400 Received: from mga01.intel.com ([192.55.52.88]:60166 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714AbcDND1Y convert rfc822-to-8bit (ORCPT ); Wed, 13 Apr 2016 23:27:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,482,1455004800"; d="scan'208";a="958254885" From: "Du, Changbin" To: Sergei Shtylyov , "balbi@kernel.org" CC: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space Thread-Topic: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space Thread-Index: AQHRlK13d4fDYt/zWE+iRtI9QMtm1J+FxnWAgAMJq6A= Date: Thu, 14 Apr 2016 03:27:19 +0000 Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A05D091F0@shsmsx102.ccr.corp.intel.com> References: <1460459419-9487-1-git-send-email-changbin.du@intel.com> <1460459419-9487-3-git-send-email-changbin.du@intel.com> <570CF0E1.1010601@cogentembedded.com> In-Reply-To: <570CF0E1.1010601@cogentembedded.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODU5N2VmMmMtN2JmYS00ZTJiLWIwMWYtMmVkYjkyNjk5ZDg5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjN0TzVldk1vUzdSZloxQzY3NjUzS0RHbFI1Y1FncllPZHNsbVdjNVJwUUE9In0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1460 Lines: 52 Hello, Sergei, > > From: "Du, Changbin" > > > > For DWC3 USB controller, the Global Debug Queue/FIFO Space Available > > Register(GDBGFIFOSPACE) can be used to dump FIFO/Queue available > space. > > Space needed before (. Okay. > > > This can be used to check some special issues, like whether data is > > successfully copied from memory to fifo when a trb is blocked. > > > > Signed-off-by: Du, Changbin > > --- > > v4: > > Do not fail silently, but print error. > [...] > > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c > > index 615d4dc..83e5bc1 100644 > > --- a/drivers/usb/dwc3/debugfs.c > > +++ b/drivers/usb/dwc3/debugfs.c > [...] > > @@ -642,10 +681,15 @@ void dwc3_debugfs_init(struct dwc3 *dwc) > > dwc->regset->nregs = ARRAY_SIZE(dwc3_regs); > > dwc->regset->base = dwc->regs; > > > > + > > Why? Thanks for point out, I will remove this additional line. > > > file = debugfs_create_regset32("regdump", S_IRUGO, root, dwc- > >regset); > > if (!file) > > dev_err(dwc->dev, "Can't create debugfs regdump\n"); > > > > + file = debugfs_create_file("fifo", S_IRUGO, root, dwc, > &dwc3_fifo_fops); > > + if (!file) > > + dev_err(dwc->dev, "Can't create debugfs fifo\n"); > > + > > if (IS_ENABLED(CONFIG_USB_DWC3_DUAL_ROLE)) { > > file = debugfs_create_file("mode", S_IRUGO | S_IWUSR, > root, > > dwc, &dwc3_mode_fops); > > MBR, Sergei