Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752884AbcDNDpw (ORCPT ); Wed, 13 Apr 2016 23:45:52 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:3670 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982AbcDNDnu (ORCPT ); Wed, 13 Apr 2016 23:43:50 -0400 Message-ID: <570F119A.4020402@huawei.com> Date: Thu, 14 Apr 2016 11:42:18 +0800 From: Weidong Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Florian Fainelli CC: David Miller , , , Subject: Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode References: <570E3488.9060403@huawei.com> <570E92ED.9020603@gmail.com> In-Reply-To: <570E92ED.9020603@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.21.100] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.570F11F1.00D7,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 81185db243472f83ce1349b83e4dabb6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 46 On 2016/4/14 2:41, Florian Fainelli wrote: > On 13/04/16 04:59, Weidong Wang wrote: >> When tested the PHY SGMII Loopback,: >> 1.set the LOOPBACK bit, >> 2.set the autoneg to AUTONEG_DISABLE, it calls the >> genphy_setup_forced which will clear the bit. >> >> So just keep the LOOPBACK bit while setup forced mode. > > Humm, it makes sense why we want this one, but maybe we want other bits > to be preserved too, like MII_ISOLATE for instance? > I will add the MII_ISOLATE as well. > Or maybe we should have a separate way to put the PHY into loopback mode > which is deterministic and takes care of forcing the link at the same time? > I test with the loopback mode, and the link status is undeterminable. >> >> Signed-off-by: Weidong Wang >> --- >> drivers/net/phy/phy_device.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c >> index e551f3a..8da4b80 100644 >> --- a/drivers/net/phy/phy_device.c >> +++ b/drivers/net/phy/phy_device.c >> @@ -1124,7 +1124,9 @@ static int genphy_config_advert(struct phy_device *phydev) >> int genphy_setup_forced(struct phy_device *phydev) >> { >> int ctl = 0; >> + int val = phy_read(phydev, MII_BMCR); >> >> + ctl |= val & BMCR_LOOPBACK; >> phydev->pause = 0; >> phydev->asym_pause = 0; >> >> -- 2.7.0 >> > >