Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753921AbcDNE1V (ORCPT ); Thu, 14 Apr 2016 00:27:21 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35943 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753883AbcDNE1T (ORCPT ); Thu, 14 Apr 2016 00:27:19 -0400 MIME-Version: 1.0 In-Reply-To: References: <1459947782-5071-1-git-send-email-ed@abdsec.com> Date: Wed, 13 Apr 2016 21:27:17 -0700 X-Google-Sender-Auth: pt28llzgXi3lgC2rnZL9LHHet7Q Message-ID: Subject: Re: [PATCH] KERNEL: resource: Fix bug on leakage in /proc/iomem file From: Kees Cook To: Linus Torvalds Cc: Emrah Demir , Linux Kernel Mailing List , Dan Rosenberg , "kernel-hardening@lists.openwall.com" , Dave Jones Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 23 On Wed, Apr 6, 2016 at 2:19 PM, Linus Torvalds wrote: > On Wed, Apr 6, 2016 at 10:54 AM, Linus Torvalds > wrote: >> >> So I'd find a patch like the attached to be perfectly acceptable (in >> fact, we should have done this long ago). > > I just committed it, let's see if some odd program uses the iomem > data. I doubt it, and I always enjoy improvements that remove more > lines of code than they add. Hrm, it looks like at least Ubuntu's kernel security test suite expects to find these entries (when it verifies that STRICT_DEVMEM hasn't regressed). Also, the commit only removed the entries on x86. Most (all?) of the other architectures still have them. Could you revert this for now, and I'll cook up a %pK-based solution for -next? -Kees -- Kees Cook Chrome OS & Brillo Security