Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754815AbcDNI5d (ORCPT ); Thu, 14 Apr 2016 04:57:33 -0400 Received: from mail-bn1bn0107.outbound.protection.outlook.com ([157.56.110.107]:24032 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751178AbcDNI52 convert rfc822-to-8bit (ORCPT ); Thu, 14 Apr 2016 04:57:28 -0400 X-Greylist: delayed 4667 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Apr 2016 04:57:27 EDT From: Manish Chopra To: Tejun Heo , Amitoj Kaur Chawla CC: Sudarsana Kalluru , netdev , linux-kernel , Dept-Eng Linux Driver , Harish Patil , Dept-GE Linux NIC Dev Subject: RE: [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue Thread-Topic: [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue Thread-Index: AQHRlawj8GqkMaHE/U6XAwqcuJM04J+JDtHQ Date: Thu, 14 Apr 2016 07:25:15 +0000 Message-ID: References: <20160409115744.GA30104@amitoj-Inspiron-3542> <20160413174422.GB3676@htj.duckdns.org> In-Reply-To: <20160413174422.GB3676@htj.duckdns.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=qlogic.com; x-originating-ip: [114.143.185.87] x-ms-office365-filtering-correlation-id: 26d58b89-fdf6-4cce-e462-08d36435ec7d x-microsoft-exchange-diagnostics: 1;BN3PR1101MB1139;5:dX7JQjI9hlBTJGVAKMofUN7+kxaJTc0nRWMGijaJQC46nraThVqeukNJK+UqG+Re6v1Y27MEGUocurkD3fEteCkr7eecxsGxwajPfyVF/EdynAwVfdSyUQVx6uhiDPx2dz8z0OBUaWGxZ8S2QC3Apw==;24:FnFV2/bxC5fM6VjxjM+lpDIelj+LQsYMKjaY2zlMz5okGCEbUbCSSFH0M/QkdP8wLS56HqGVieC1kduYIvsZ/u939LmZJ9Ylwga1pI0/+3c=;20:roiyMm/qB73xirUtRbhBJRL0cHyhNrJu2wkZAr3Wq0vX3YfnXWg0YTIHG3CaHH4OdxlC5v2Jzg4tGkeuyJ45aKIlu9ovrDPGnj6J/rq8lr48sklIi3OtIgrF/rBfC9gj6yAAgM2ukZSMHSflfgRtKnkDpVd9J6b3de/MY0648FQ= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR1101MB1139; x-ld-processed: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN3PR1101MB1139;BCL:0;PCL:0;RULEID:;SRVR:BN3PR1101MB1139; x-forefront-prvs: 0912297777 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(13464003)(24454002)(54356999)(76176999)(10400500002)(2950100001)(2900100001)(77096005)(5003600100002)(76576001)(5001770100001)(189998001)(122556002)(33656002)(86362001)(5002640100001)(5004730100002)(107886002)(50986999)(92566002)(87936001)(3280700002)(66066001)(81166005)(4326007)(4001430100002)(5008740100001)(106116001)(3660700001)(586003)(2906002)(99286002)(74316001)(102836003)(3846002)(6116002)(9686002)(19580395003)(1220700001)(19580405001)(1096002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR1101MB1139;H:BLUPR11MB0114.namprd11.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2016 07:25:15.0745 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR1101MB1139 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 39 > -----Original Message----- > From: dept_hsg_linux_nic_dev-bounces@qlclistserver.qlogic.com > [mailto:dept_hsg_linux_nic_dev-bounces@qlclistserver.qlogic.com] On Behalf > Of Tejun Heo > Sent: Wednesday, April 13, 2016 11:14 PM > To: Amitoj Kaur Chawla > Cc: Sudarsana Kalluru ; netdev > ; linux-kernel ; Dept- > Eng Linux Driver ; Harish Patil > ; Dept-GE Linux NIC Dev GELinuxNICDev@qlogic.com> > Subject: Re: [PATCH] qlge: Replace create_singlethread_workqueue with > alloc_ordered_workqueue > > On Sat, Apr 09, 2016 at 05:27:45PM +0530, Amitoj Kaur Chawla wrote: > > Replace deprecated create_singlethread_workqueue with > > alloc_ordered_workqueue. > > > > Work items include getting tx/rx frame sizes, resetting MPI processor, > > setting asic recovery bit so ordering seems necessary as only one work > > item should be in queue/executing at any given time, hence the use of > > alloc_ordered_workqueue. > > > > WQ_MEM_RECLAIM flag has been set since ethernet devices seem to sit in > > memory reclaim path, so to guarantee forward progress regardless of > > memory pressure. > > > > Signed-off-by: Amitoj Kaur Chawla > > Acked-by: Tejun Heo > > Ping? > Hi, Just want to confirm that __WQ_LEGACY flag is not necessary here as this is removed with this change ? Thanks