Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932079AbcDNI55 (ORCPT ); Thu, 14 Apr 2016 04:57:57 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41000 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754825AbcDNI5x (ORCPT ); Thu, 14 Apr 2016 04:57:53 -0400 Date: Thu, 14 Apr 2016 09:57:07 +0100 From: Mark Brown To: Cyrille Pitchen Cc: Lakshmi Sai Krishna Potthuri , Michal Simek , Soren Brinkmann , David Woodhouse , Brian Norris , Javier Martinez Canillas , Boris Brezillon , Stephen Warren , Geert Uytterhoeven , "Andrew F. Davis" , Marek Vasut , Jagan Teki , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Harini Katakam , Punnaiah Choudary Kalluri , Anirudha Sarangi , "R, Vignesh" Message-ID: <20160414085707.GE18024@sirena.org.uk> References: <1460039969-9835-1-git-send-email-lakshmis@xilinx.com> <57067694.8030806@atmel.com> <4FF8F58FAA9D5D4193D4E554E4352C5902C720DE@XAP-PVEXMBX02.xlnx.xilinx.com> <570F4F9F.3090605@atmel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tMbDGjvJuJijemkf" Content-Disposition: inline In-Reply-To: <570F4F9F.3090605@atmel.com> X-Cookie: McDonald's -- Because you're worth it. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [LINUX PATCH v2 1/3] spi: Added dummy_cycle entry in the spi_transfer structure. X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 31 --tMbDGjvJuJijemkf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 14, 2016 at 10:06:55AM +0200, Cyrille Pitchen wrote: > I understand but you propose to patch both the SPI layer and the m25p80 driver > to introduce some support which is already provided by the "spi_flash_read" > hook: struct spi_flash_read_message has already a "dummy_bytes" field. > IMHO, it looks redundant. My understanding is that this is intended for dummy bits rather than dummy bytes. --tMbDGjvJuJijemkf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXD1thAAoJECTWi3JdVIfQJLEH/1Ory7hYtXNRM/1zIu//pJ1W lVNGpgHzgCgeNYk/k0HSdx3g75axhTV3XP2c+clxtieEa7cIf1hY6KqFg4E00xTh BtIhJQFvg84dYi3X0ZRfg/0VwCpf2FcQU3OTYu8SlIY/dbW22sKg+enCMr3D5Swi Vrqw/yIRPtzLpsJ8+RA9ShC5yHtGgMaOkaSj6ydQE3ggECKTu1k0tGCLQ/U9Yvzb gmkYZW2+lDho43qBEAyGbU1XJfbQdymBBZ1o73oJazRVV4wPbNt1o/9BzcGXAA4k +mtjEWJZIChEkIMwYV6eXa1xgGPaRnFLGcR8RyivHovubwQXtux/550bo7IaVd4= =T88m -----END PGP SIGNATURE----- --tMbDGjvJuJijemkf--