Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754260AbcDNJ1Y (ORCPT ); Thu, 14 Apr 2016 05:27:24 -0400 Received: from mga04.intel.com ([192.55.52.120]:32743 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753508AbcDNJ1W (ORCPT ); Thu, 14 Apr 2016 05:27:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,484,1455004800"; d="scan'208";a="686115726" Date: Thu, 14 Apr 2016 12:27:13 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH v3] tpm: fix crash in tpm_tis deinitialization Message-ID: <20160414092713.GA5715@intel.com> References: <1460532126-14435-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160413171127.GB28411@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160413171127.GB28411@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1337 Lines: 39 On Wed, Apr 13, 2016 at 11:11:27AM -0600, Jason Gunthorpe wrote: > On Wed, Apr 13, 2016 at 10:22:06AM +0300, Jarkko Sakkinen wrote: > > rmmod crashes the driver because tpm_chip_unregister() already sets ops > > to NULL. This commit fixes the issue by moving tpm2_shutdown() to > > tpm_chip_unregister(). This commit is also cleanup because it removes > > duplicate code from tpm_crb and tpm_tis to the core. > > > > v2: make sending shutdown command atomic with nulling ops > > v3: forgot to amend updates, sorry :( > > Signed-off-by: Jarkko Sakkinen > > Fixes: 4d3eac5e156a ("tpm: Provide strong locking for device > > removal") > > You patch got a little mangled.. The v2/v3 should be after the > diffstat, not in the commit message and the --- after the SOB section > is missing.. > > Otherwise it looks fine > > Reviewed-by: Jason Gunthorpe Thanks I'll apply this. /Jarkko > > extern int tpm2_startup(struct tpm_chip *chip, u16 startup_type); > > -extern void tpm2_shutdown(struct tpm_chip *chip, u16 shutdown_type); > > +void tpm2_shutdown(struct tpm_chip *chip, u16 shutdown_type); > > Drop this hunk though, doesn't do anything. > > If you don't like the unnecessary externs on functions then get rid of > them all in a patch. [x] > Jason /Jarkko