Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754058AbcDNJgG (ORCPT ); Thu, 14 Apr 2016 05:36:06 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:45708 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752974AbcDNJgC (ORCPT ); Thu, 14 Apr 2016 05:36:02 -0400 Date: Thu, 14 Apr 2016 12:35:48 +0300 From: Dan Carpenter To: Evgeniy Polyakov Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] w1: silence an uninitialized variable warning Message-ID: <20160414093548.GG16549@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 539 Lines: 17 If kstrtoint() returns -ERANGE then "tmp" is uninitialized. Signed-off-by: Dan Carpenter diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 89a7847..bb34362 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -335,7 +335,7 @@ static ssize_t w1_master_attribute_store_max_slave_count(struct device *dev, int tmp; struct w1_master *md = dev_to_w1_master(dev); - if (kstrtoint(buf, 0, &tmp) == -EINVAL || tmp < 1) + if (kstrtoint(buf, 0, &tmp) || tmp < 1) return -EINVAL; mutex_lock(&md->mutex);