Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754417AbcDNOGa (ORCPT ); Thu, 14 Apr 2016 10:06:30 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:33525 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226AbcDNOG3 (ORCPT ); Thu, 14 Apr 2016 10:06:29 -0400 MIME-Version: 1.0 In-Reply-To: <570F9E4D.7040401@collabora.com> References: <1460119972-8658-1-git-send-email-enric.balletbo@collabora.com> <1460119972-8658-4-git-send-email-enric.balletbo@collabora.com> <20160414131013.GA32237@ulmo.ba.sec> <570F9E4D.7040401@collabora.com> Date: Thu, 14 Apr 2016 15:06:27 +0100 Message-ID: Subject: Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support. From: Emil Velikov To: Enric Balletbo i Serra Cc: Thierry Reding , devicetree , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , David Airlie , Rob Herring , Daniel Kurtz , drinkcat@chromium.org, Dan Carpenter , Rob Herring Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 22 Hi Enric, On 14 April 2016 at 14:42, Enric Balletbo i Serra wrote: > The patch was implemented first without OR'ing error codes. The reason why I > changed this is because I received the comments that checking the error on > every regmap_* didn't help the readability of the driver and is likely to > not fail if the first call doesn't fail. > > For example, originally the code was like this: > http://pastebin.com/rPgyji8k > but I changed to this > http://pastebin.com/rPgyji8k > Both links are the same ;-) But I believe we all get what you meant. Just a side note: many other drivers in DRM subsystem, inconsistently check the return value of the regmap API. Note sure how likely is any of it [regmap_foo] to fail and/or how determined people are to handle every possible error case. -Emil