Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755871AbcDNOLV (ORCPT ); Thu, 14 Apr 2016 10:11:21 -0400 Received: from foss.arm.com ([217.140.101.70]:43042 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755824AbcDNOLT (ORCPT ); Thu, 14 Apr 2016 10:11:19 -0400 Subject: Re: [PATCH v2 01/17] arm64: Reuse TCR field definitions for EL1 and EL2 To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org References: <1460640065-27658-1-git-send-email-suzuki.poulose@arm.com> <1460640065-27658-2-git-send-email-suzuki.poulose@arm.com> Cc: kvm@vger.kernel.org, christoffer.dall@linaro.org, mark.rutland@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu From: Marc Zyngier Organization: ARM Ltd Message-ID: <570FA503.6040705@arm.com> Date: Thu, 14 Apr 2016 15:11:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <1460640065-27658-2-git-send-email-suzuki.poulose@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 754 Lines: 21 On 14/04/16 14:20, Suzuki K Poulose wrote: > TCR_EL1, TCR_EL2 and VTCR_EL2, all share some field positions > (TG0, ORGN0, IRGN0 and SH0) and their corresponding value definitions. > > This patch makes the TCR_EL1 definitions reusable and uses them for TCR_EL2 > and VTCR_EL2 fields. > > This also fixes a bug where we assume TG0 in {V}TCR_EL2 is 1bit field. > > Cc: Catalin Marinas > Cc: Mark Rutland > Cc: Will Deacon > Cc: Marc Zyngier > Reviewed-by: Christoffer Dall > Signed-off-by: Suzuki K Poulose Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny...