Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964806AbcDNPRQ (ORCPT ); Thu, 14 Apr 2016 11:17:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35906 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932118AbcDNPRM (ORCPT ); Thu, 14 Apr 2016 11:17:12 -0400 Date: Thu, 14 Apr 2016 16:17:05 +0100 From: Aaron Tomlin To: Chris Metcalf Cc: Peter Zijlstra , "Rafael J. Wysocki" , Petr Mladek , Russell King , Thomas Gleixner , Ingo Molnar , Andrew Morton , Daniel Thompson , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Message-ID: <20160414151705.GE20425@atomlin.usersys.redhat.com> References: <1459877208-15119-1-git-send-email-cmetcalf@mellanox.com> <1459877208-15119-2-git-send-email-cmetcalf@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1459877208-15119-2-git-send-email-cmetcalf@mellanox.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1210 Lines: 30 On Tue 2016-04-05 13:26 -0400, Chris Metcalf wrote: > Currently you can only request a backtrace of either all cpus, or > all cpus but yourself. It can also be helpful to request a remote > backtrace of a single cpu, and since we want that, the logical > extension is to support a cpumask as the underlying primitive. > > This change modifies the existing lib/nmi_backtrace.c code to take > a cpumask as its basic primitive, and modifies the linux/nmi.h code > to use either the old "all/all_but_self" arch methods, or the new > "cpumask" method, depending on which is available. > > The existing clients of nmi_backtrace (arm and x86) are converted > to using the new cpumask approach in this change. > > Signed-off-by: Chris Metcalf > --- > arch/arm/include/asm/irq.h | 4 +-- > arch/arm/kernel/smp.c | 4 +-- > arch/x86/include/asm/irq.h | 4 +-- > arch/x86/kernel/apic/hw_nmi.c | 6 ++--- > include/linux/nmi.h | 63 ++++++++++++++++++++++++++++++++++--------- > lib/nmi_backtrace.c | 15 +++++------ > 6 files changed, 65 insertions(+), 31 deletions(-) Looks good to me. Reviewed-by: Aaron Tomlin -- Aaron Tomlin