Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932693AbcDNPlH (ORCPT ); Thu, 14 Apr 2016 11:41:07 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41798 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755237AbcDNPlF (ORCPT ); Thu, 14 Apr 2016 11:41:05 -0400 Date: Thu, 14 Apr 2016 16:40:59 +0100 From: Mark Brown To: James Bans Cc: LINUXKERNEL , Liam Girdwood , Support Opensource Message-ID: <20160414154059.GI18024@sirena.org.uk> References: <20160414075124.B874A5F7F3@krsrvapps-01.diasemi.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dCSxeJc5W8HZXZrD" Content-Disposition: inline In-Reply-To: <20160414075124.B874A5F7F3@krsrvapps-01.diasemi.com> X-Cookie: McDonald's -- Because you're worth it. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V1] regulator: pv88080: new regulator driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1409 Lines: 50 --dCSxeJc5W8HZXZrD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 14, 2016 at 04:32:04PM +0900, James Bans wrote: A couple of minor points but otherwise this looks good: > +static const int pv88080_buck2_limits[] = { > + 1496000, 2393000, 3291000, 4189000 > +}; > + > +static const int pv88080_buck3_limits[] = { > + 1496000, 2393000, 3291000, 4189000 > +}; These two appear identical so should just be one array. > + switch (data & PV88080_BUCK1_MODE_MASK) { > + case PV88080_BUCK_MODE_SYNC: > + mode = REGULATOR_MODE_FAST; > + break; > + case PV88080_BUCK_MODE_AUTO: > + mode = REGULATOR_MODE_NORMAL; > + break; > + case PV88080_BUCK_MODE_SLEEP: > + mode = REGULATOR_MODE_STANDBY; > + break; > + } I know mode was initialized above but this would be clearer with a default: case. --dCSxeJc5W8HZXZrD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXD7oJAAoJECTWi3JdVIfQfVMIAICKVJtTEI8MstyXYVe0eDL2 vhZmC1mS2E3c06AV3BwodJbhOpyn84TbPt/LSGT4NXcE4zETttPTcZjsGHRTQD3M rnDVimaV7qsDPziX3AqaoLCX2av1apGDih2tQdhXwd1dCZmvnF+u5eKQFktm2EIu v30yxPw5guP0fXJemvkmgDVzsWDRNTATuuQcGDGve6wwjZh7I4a8ANghOpUqEQRj ooubjdwZQtmrKR+k4ibzoiXHBp96WpEg/txKpkDgDOV/QVJmvHZbqvhuiNVbYy2Q KLKqeIei7nkkAEf2GvMKO8/uS1YOVoLB7GZo+opGGuQkEE20aNMMkE5hPp/JRhQ= =VUG8 -----END PGP SIGNATURE----- --dCSxeJc5W8HZXZrD--