Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932891AbcDNPpZ (ORCPT ); Thu, 14 Apr 2016 11:45:25 -0400 Received: from mail-qg0-f66.google.com ([209.85.192.66]:35068 "EHLO mail-qg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbcDNPpU (ORCPT ); Thu, 14 Apr 2016 11:45:20 -0400 Date: Thu, 14 Apr 2016 11:45:17 -0400 From: Tejun Heo To: Yoshinori Sato Cc: Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pata_artop: Use ioread8. Message-ID: <20160414154517.GD12583@htj.duckdns.org> References: <1460618763-1712-1-git-send-email-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460618763-1712-1-git-send-email-ysato@users.sourceforge.jp> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 28 Hello, On Thu, Apr 14, 2016 at 04:26:03PM +0900, Yoshinori Sato wrote: > Support for non x86 targets. Being a bit more detailed would be nice. > Signed-off-by: Yoshinori Sato > --- > drivers/ata/pata_artop.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c > index 96c05c9..3731dea 100644 > --- a/drivers/ata/pata_artop.c > +++ b/drivers/ata/pata_artop.c > @@ -340,6 +340,18 @@ static void atp8xx_fixup(struct pci_dev *pdev) > } > } > > +static int is_fast(struct pci_dev *pdev) Can you please make the name a bit more descriptive? Thanks. -- tejun