Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756111AbcDNPrG (ORCPT ); Thu, 14 Apr 2016 11:47:06 -0400 Received: from mail-qg0-f65.google.com ([209.85.192.65]:35538 "EHLO mail-qg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754864AbcDNPrD (ORCPT ); Thu, 14 Apr 2016 11:47:03 -0400 Date: Thu, 14 Apr 2016 11:47:00 -0400 From: Tejun Heo To: Manish Chopra Cc: Amitoj Kaur Chawla , Sudarsana Kalluru , netdev , linux-kernel , Dept-Eng Linux Driver , Harish Patil , Dept-GE Linux NIC Dev Subject: Re: [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue Message-ID: <20160414154700.GE12583@htj.duckdns.org> References: <20160409115744.GA30104@amitoj-Inspiron-3542> <20160413174422.GB3676@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 489 Lines: 16 Hello, Manish. On Thu, Apr 14, 2016 at 07:25:15AM +0000, Manish Chopra wrote: > Just want to confirm that __WQ_LEGACY flag is not necessary here as this is removed > with this change ? Yeah, that should be fine. That only affects locking dependency tracking which can fire spuriously due to workqueues created with the old interface having WQ_MEM_RECLAIM unconditionally. In this case, we actually want WQ_MEM_RECLAIM and thus we want the dependency tracking too. Thanks. -- tejun