Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932620AbcDNQIU (ORCPT ); Thu, 14 Apr 2016 12:08:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:53340 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755198AbcDNQIT (ORCPT ); Thu, 14 Apr 2016 12:08:19 -0400 Date: Thu, 14 Apr 2016 18:08:14 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Phil Sutter cc: Eric Dumazet , Jamal Hadi Salim , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Deleting child qdisc doesn't reset parent to default qdisc? In-Reply-To: <20160414151813.GE3715@orbyte.nwl.cc> Message-ID: References: <1460646099.10638.44.camel@edumazet-glaptop3.roam.corp.google.com> <20160414151813.GE3715@orbyte.nwl.cc> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 24 On Thu, 14 Apr 2016, Phil Sutter wrote: > > > I've came across the behavior where adding a child qdisc and then deleting > > > it again makes the networking dysfunctional (I guess that's because all of > > > a sudden there is absolutely no working qdisc on the device, although > > > there originally was a default one in the parent). > > > > > > In a nutshell, is this expected behavior or bug? > > > > This is the expected behavior. > > OTOH some qdiscs (CBQ, DRR, DSMARK, HFSC, HTB, QFQ) assign the default > one upon deletion instead of noop_qdisc, hence I would describe > the situation using the words 'inconsistent' and 'accident' rather than > 'expected'. :) Would a patch that'd unify this in a sense that all qdiscs would assign the default one upon deletion acceptable? Thanks, -- Jiri Kosina SUSE Labs