Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932968AbcDNQYP (ORCPT ); Thu, 14 Apr 2016 12:24:15 -0400 Received: from mail.kernel.org ([198.145.29.136]:43869 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964888AbcDNQYN (ORCPT ); Thu, 14 Apr 2016 12:24:13 -0400 Date: Thu, 14 Apr 2016 11:24:07 -0500 From: Rob Herring To: Timur Tabi Cc: kbuild test robot , kbuild-all@01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sdharia@codeaurora.org, Shanker Donthineni , Greg Kroah-Hartman , vikrams@codeaurora.org, cov@codeaurora.org, gavidov@codeaurora.org, andrew@lunn.ch, bjorn.andersson@linaro.org, Mark Langsdorf , Jon Masters , Andy Gross , "David S. Miller" Subject: Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver Message-ID: <20160414162407.GA15303@rob-hp-laptop> References: <201604140340.wQZLwsUk%fengguang.wu@intel.com> <570E9E8D.50007@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <570E9E8D.50007@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 21 On Wed, Apr 13, 2016 at 02:31:25PM -0500, Timur Tabi wrote: > kbuild test robot wrote: > > > > drivers/net/ethernet/qualcomm/emac/emac-mac.c: In function 'emac_mac_up': > >>>>>drivers/net/ethernet/qualcomm/emac/emac-mac.c:1076:9: warning: large integer implicitly truncated to unsigned type [-Woverflow] > > writel(~DIS_INT, adpt->base + EMAC_INT_STATUS); > > This doesn't happen on arm64, and I don't know how to fix it. DIS_INT is > defined as: Probably depends on the compiler version. BTW, clang seems to throw errors for this type of thing. > > #define DIS_INT BIT(31) > > It seems silly to add a typecast to DIS_INT. BIT() should use 1U instead of 1. Rob