Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756372AbcDNQdL (ORCPT ); Thu, 14 Apr 2016 12:33:11 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:33906 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756177AbcDNQdJ (ORCPT ); Thu, 14 Apr 2016 12:33:09 -0400 Subject: Re: [PATCH] arm64: Kconfig: make SCHED_MC and SCHED_SMT depend on SMP To: Will Deacon References: <1460595252-2330-1-git-send-email-yang.shi@linaro.org> <20160414084727.GA23207@arm.com> Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org From: "Shi, Yang" Message-ID: <570FC643.3090805@linaro.org> Date: Thu, 14 Apr 2016 09:33:07 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160414084727.GA23207@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 23 On 4/14/2016 1:47 AM, Will Deacon wrote: > On Wed, Apr 13, 2016 at 05:54:12PM -0700, Yang Shi wrote: >> SCHED_MC and SCHED_SMT are pointless when SMP is disabled. >> Although SMP is rarely disabled for ARM64, it looks more consistent to have >> such depend in Kconfig. > > You can't disable CONFIG_SMP for arm64 -- we select it unconditionally > in the kconfig. Thanks Will. I didn't realize ARM64 has SMP selected unconditionally, it looks the patch is pointless. A follow-up question, I know ARM64 has no UP implementation now, it sounds make sense to have SMP select unconditionally, however, it might be more flexible to have SMP like x86 and other architectures. And, it may also help to find more bugs when !SMP. Thanks, Yang > > Will >