Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422661AbcDNQ5G (ORCPT ); Thu, 14 Apr 2016 12:57:06 -0400 Received: from mail.kernel.org ([198.145.29.136]:46859 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755078AbcDNQ5E (ORCPT ); Thu, 14 Apr 2016 12:57:04 -0400 Date: Thu, 14 Apr 2016 09:57:00 -0700 From: Shaohua Li To: Dan Carpenter Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch v2] md/raid0: fix uninitialized variable bug Message-ID: <20160414165700.GA2006@kernel.org> References: <20160413170240.GB6186@kernel.org> <20160414093149.GA16549@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160414093149.GA16549@mwanda> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 356 Lines: 8 On Thu, Apr 14, 2016 at 12:31:49PM +0300, Dan Carpenter wrote: > If this function fails the callers expect that *private_conf is set to > an ERR_PTR() but that isn't true for the first error path where we can't > allocate "conf". It leads to some uninitialized variable bugs. > > Signed-off-by: Dan Carpenter Applied, thanks!