Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422683AbcDNRTH (ORCPT ); Thu, 14 Apr 2016 13:19:07 -0400 Received: from mail.kernel.org ([198.145.29.136]:48532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754863AbcDNRTE (ORCPT ); Thu, 14 Apr 2016 13:19:04 -0400 MIME-Version: 1.0 In-Reply-To: <570FC987.80304@codeaurora.org> References: <1460570393-19838-1-git-send-email-timur@codeaurora.org> <20160414163240.GB15303@rob-hp-laptop> <570FC987.80304@codeaurora.org> From: Rob Herring Date: Thu, 14 Apr 2016 12:18:38 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver To: Timur Tabi Cc: netdev , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , linux-arm-msm , Sagar Dharia , Shanker Donthineni , Greg Kroah-Hartman , vikrams@codeaurora.org, Christopher Covington , Gilad Avidov , Andrew Lunn , Bjorn Andersson , Mark Langsdorf , Jon Masters , Andy Gross , "David S. Miller" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1722 Lines: 48 On Thu, Apr 14, 2016 at 11:47 AM, Timur Tabi wrote: > Rob Herring wrote: > >>> @@ -0,0 +1,65 @@ >>> +Qualcomm EMAC Gigabit Ethernet Controller >>> + >>> +Required properties: >>> +- compatible : Should be "qcom,emac". >> >> >> Come on... Can you guess what I'm going to say here. > > > Ooops, I missed that one. > >> >>> +- reg : Offset and length of the register regions for the device >>> +- reg-names : Register region names referenced in 'reg' above. >>> + Required register resource entries are: >>> + "base" : EMAC controller base register block. >>> + "csr" : EMAC wrapper register block. >>> + Optional register resource entries are: >>> + "ptp" : EMAC PTP (1588) register block. >>> + Required if 'qcom,emac-tstamp-en' is present. >>> + "sgmii" : EMAC SGMII PHY register block. >>> +- interrupts : Interrupt numbers used by this controller >>> +- interrupt-names : Interrupt resource names referenced in 'interrupts' >>> above. >>> + Required interrupt resource entries are: >>> + "emac_core0" : EMAC core0 interrupt. >>> + "sgmii_irq" : EMAC SGMII interrupt. >>> +- phy-addr : Specifies phy address on MDIO bus. >>> + Required if the optional property >>> "qcom,no-external-phy" >>> + is not specified. >> >> >> As I mentioned in the last version, you should still describe this with >> a standard MDIO bus binding even if you can't use the generic code. > > > You mean like this? > > phy0: ethernet-phy@0 { > compatible = "qcom,fsm9900-emac-phy"; > reg = <4>; Yes, but you mean 0 here or 4 for unit address.