Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755530AbcDNR7Z (ORCPT ); Thu, 14 Apr 2016 13:59:25 -0400 Received: from mga04.intel.com ([192.55.52.120]:3929 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753428AbcDNR7X (ORCPT ); Thu, 14 Apr 2016 13:59:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,485,1455004800"; d="scan'208";a="85303037" Date: Thu, 14 Apr 2016 13:59:22 -0400 From: Ira Weiny To: Markus =?iso-8859-1?Q?B=F6hme?= Cc: devel@driverdev.osuosl.org, Mike Marciniszyn , Doug Ledford , Sean Hefty , Hal Rosenstock , Greg Kroah-Hartman , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging/rdma/hfi1: select CRC32 Message-ID: <20160414175922.GB11641@rhel.sc.intel.com> References: <1459465467-31367-1-git-send-email-markus.boehme@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1459465467-31367-1-git-send-email-markus.boehme@mailbox.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1198 Lines: 36 On Fri, Apr 01, 2016 at 01:04:05AM +0200, Markus B?hme wrote: > The function parse_platform_config in firmware.c calls crc32_le. > Building without CRC32 selected causes a link error: > > drivers/built-in.o: In function `parse_platform_config': > (.text+0x92ffa): undefined reference to `crc32_le' > > Signed-off-by: Markus B?hme Doug did you pick this up? Reviewed-by: Ira Weiny > --- > drivers/staging/rdma/hfi1/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/rdma/hfi1/Kconfig b/drivers/staging/rdma/hfi1/Kconfig > index 3e668d8..a925fb0 100644 > --- a/drivers/staging/rdma/hfi1/Kconfig > +++ b/drivers/staging/rdma/hfi1/Kconfig > @@ -2,6 +2,7 @@ config INFINIBAND_HFI1 > tristate "Intel OPA Gen1 support" > depends on X86_64 && INFINIBAND_RDMAVT > select MMU_NOTIFIER > + select CRC32 > default m > ---help--- > This is a low-level driver for Intel OPA Gen1 adapter. > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html