Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbcDNTYy (ORCPT ); Thu, 14 Apr 2016 15:24:54 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:35039 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbcDNTYs (ORCPT ); Thu, 14 Apr 2016 15:24:48 -0400 MIME-Version: 1.0 In-Reply-To: <1460661464-11216-3-git-send-email-boris.brezillon@free-electrons.com> References: <1460661464-11216-1-git-send-email-boris.brezillon@free-electrons.com> <1460661464-11216-3-git-send-email-boris.brezillon@free-electrons.com> Date: Thu, 14 Apr 2016 21:24:47 +0200 Message-ID: Subject: Re: [PATCH v5 02/24] pwm: use pwm_get/set_xxx() helpers where appropriate From: Joachim Eastwood To: Boris Brezillon Cc: Thierry Reding , linux-pwm@vger.kernel.org, Mike Turquette , Stephen Boyd , linux-clk , Mark Brown , Liam Girdwood , Kamil Debski , lm-sensors@lm-sensors.org, Jean Delvare , Guenter Roeck , Dmitry Torokhov , linux-input@vger.kernel.org, Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Thomas Petazzoni , Heiko Stuebner , linux-rockchip@lists.infradead.org, Jingoo Han , Lee Jones , linux-fbdev@vger.kernel.org, Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Robert Jarzmik , Alexandre Belloni , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, Daniel Vetter , Jani Nikula , Jonathan Corbet , linux-doc@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Hartley Sweeten , Ryan Mallon , Alexander Shiyan , Milo Kim , Doug Anderson , Caesar Wang , Stephen Barber Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1671 Lines: 61 On 14 April 2016 at 21:17, Boris Brezillon wrote: > Use pwm_get/set_xxx() helpers instead of directly accessing the pwm->xxx > field. Doing that will ease adaptation of the PWM framework to support > atomic update. > > Signed-off-by: Boris Brezillon > --- > Patch generated with the following coccinelle script: > > --->8--- > virtual patch > > @@ > struct pwm_device *p; > expression e; > @@ > ( > -(p)->polarity = e; > +pwm_set_polarity(p, e); > | > -(p)->polarity > +pwm_get_polarity(p) > | > -(p)->period = e; > +pwm_set_period(p, e); > | > -(p)->period > +pwm_get_period(p) > | > -(p)->duty_cycle = e; > +pwm_set_duty_cycle(p, e); > | > -(p)->duty_cycle > +pwm_get_duty_cycle(p) > ) > --->8--- > --- > drivers/pwm/pwm-crc.c | 2 +- > drivers/pwm/pwm-lpc18xx-sct.c | 2 +- > diff --git a/drivers/pwm/pwm-lpc18xx-sct.c b/drivers/pwm/pwm-lpc18xx-sct.c > index 9861fed..19dc64c 100644 > --- a/drivers/pwm/pwm-lpc18xx-sct.c > +++ b/drivers/pwm/pwm-lpc18xx-sct.c > @@ -249,7 +249,7 @@ static int lpc18xx_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) > LPC18XX_PWM_EVSTATEMSK(lpc18xx_data->duty_event), > LPC18XX_PWM_EVSTATEMSK_ALL); > > - if (pwm->polarity == PWM_POLARITY_NORMAL) { > + if (pwm_get_polarity(pwm) == PWM_POLARITY_NORMAL) { > set_event = lpc18xx_pwm->period_event; > clear_event = lpc18xx_data->duty_event; > res_action = LPC18XX_PWM_RES_SET; For the lpc18xx-sct part: Acked-by: Joachim Eastwood regards, Joachim Eastwood