Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751557AbcDNUFo (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Apr 2016 16:05:44 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:42810 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751044AbcDNUFn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Apr 2016 16:05:43 -0400
Date: Thu, 14 Apr 2016 23:05:00 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Gabriel L. Somlo" <somlo@cmu.edu>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] firmware: qemu_fw_cfg.c: potential unintialized variable
Message-ID: <20160414200500.GI4247@mwanda>
References: <20160414093337.GD16549@mwanda>
 <20160414184005.GC7821@HEDWIG.INI.CMU.EDU>
 <20160414191253.GH4247@mwanda>
 <20160414193614.GE7821@HEDWIG.INI.CMU.EDU>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160414193614.GE7821@HEDWIG.INI.CMU.EDU>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 364
Lines: 11

Ah...  I see now.  You're right.  Thanks for the explanation.

On my config those functions are no-ops so the variable isn't
initialized.  If they were enabled then *probably* it wouldn't generate
a warning.

Probably just silencing the warning is the way to go though...  I bet
GCC optimizes it away.  Let me think about this some more...

regards,
dan carpenter