Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751836AbcDNUvJ (ORCPT ); Thu, 14 Apr 2016 16:51:09 -0400 Received: from mail-yw0-f177.google.com ([209.85.161.177]:33450 "EHLO mail-yw0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751706AbcDNUvH (ORCPT ); Thu, 14 Apr 2016 16:51:07 -0400 MIME-Version: 1.0 In-Reply-To: <1460656118-16766-5-git-send-email-gustavo@padovan.org> References: <1460656118-16766-1-git-send-email-gustavo@padovan.org> <1460656118-16766-5-git-send-email-gustavo@padovan.org> Date: Thu, 14 Apr 2016 16:51:06 -0400 Message-ID: Subject: Re: [PATCH 05/14] drm/msm: use drm_crtc_send_vblank_event() From: Rob Clark To: Gustavo Padovan Cc: "dri-devel@lists.freedesktop.org" , Gustavo Padovan , David Airlie , Daniel Vetter , Ander Conselvan de Oliveira , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Carlos Palminha , Hai Li , Maarten Lankhorst , Archit Taneja , Daniel Stone , jilai wang , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2142 Lines: 46 On Thu, Apr 14, 2016 at 1:48 PM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Replace the legacy drm_send_vblank_event() with the new helper function. > > Signed-off-by: Gustavo Padovan thanks, shall I take this via msm-next for 4.7, I assume? Looks like no dependency on drm-core patches that haven't already landed? Reviewed-by: Rob Clark > --- > drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 2 +- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > index e233acf..3a48889 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > @@ -121,7 +121,7 @@ static void complete_flip(struct drm_crtc *crtc, struct drm_file *file) > if (!file || (event->base.file_priv == file)) { > mdp4_crtc->event = NULL; > DBG("%s: send event: %p", mdp4_crtc->name, event); > - drm_send_vblank_event(dev, mdp4_crtc->id, event); > + drm_crtc_send_vblank_event(crtc, event); > } > } > spin_unlock_irqrestore(&dev->event_lock, flags); > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > index 9673b95..ce779d9 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > @@ -149,7 +149,7 @@ static void complete_flip(struct drm_crtc *crtc, struct drm_file *file) > if (!file || (event->base.file_priv == file)) { > mdp5_crtc->event = NULL; > DBG("%s: send event: %p", mdp5_crtc->name, event); > - drm_send_vblank_event(dev, mdp5_crtc->id, event); > + drm_crtc_send_vblank_event(crtc, event); > } > } > spin_unlock_irqrestore(&dev->event_lock, flags); > -- > 2.5.5 >