Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752451AbcDNWWh (ORCPT ); Thu, 14 Apr 2016 18:22:37 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:49671 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbcDNWWg (ORCPT ); Thu, 14 Apr 2016 18:22:36 -0400 MIME-Version: 1.0 In-Reply-To: <570FA4F7.6020301@kernel.dk> References: <1460634438-26530-1-git-send-email-ming.lei@canonical.com> <570FA4F7.6020301@kernel.dk> Date: Fri, 15 Apr 2016 06:22:33 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/8] block: prepare for multipage bvecs From: Ming Lei To: Jens Axboe Cc: Jens Axboe , Linux Kernel Mailing List , linux-block@vger.kernel.org, Christoph Hellwig , Al Viro , "open list:DRBD DRIVER" , Jan Kara , Keith Busch , Kent Overstreet , "Kirill A. Shutemov" , Mike Snitzer , Shaohua Li , Tejun Heo , "open list:XFS FILESYSTEM" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1261 Lines: 35 On Thu, Apr 14, 2016 at 10:11 PM, Jens Axboe wrote: > On 04/14/2016 05:46 AM, Ming Lei wrote: >> >> Hi, >> >> Interests[1] have been shown in multipage bvecs, so this patchset >> try to prepare for the support and do two things: >> >> 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), >> then we can drop the non-standard way for iterating bvec, which >> can be thought as a good cleanup for lib/iov_iter.c >> >> 2) remove BIO_MAX_SECTORS & BIO_MAX_SIZE, and now there is only >> one user for each. Once multipage bvecs is introduced, one bio >> may hold lots of sectors, and we should always use sort of BIO_MAX_VECS >> which should be introduced in future and is similiar with current >> BIO_MAX_PAGES. >> >> xfstests(-a auto) have been run over ext4/xfs and no regression found >> by this patchset. > > > We've had too many disasters in the block layer the last few series, I'm > making the 4.7 round a nice and small one. I don't mind taking prep patches > for the multipage bvecs, if they are simple and clean, but that's about the > extent of it. > > Just a heads up. Jens, thanks for your response, and understood your concerns. Please hold on this patchset, and I will check it further and make it better. Thanks,