Date: Thu, 14 Apr 2016 17:34:29 -0700
From: Darren Hart <dvhart@infradead.org>
To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= 
	<giedrius.statkevicius@gmail.com>
Cc: corentin.chary@gmail.com, acpi4asus-user@lists.sourceforge.net,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] asus-laptop: remove unused variable
Message-ID: <20160415003429.GB3232@f23x64.localdomain>
References: <1460060401-20742-1-git-send-email-giedrius.statkevicius@gmail.com>
 <1460060401-20742-2-git-send-email-giedrius.statkevicius@gmail.com>
 <20160410032121.GD18689@dvhart-mobl5.amr.corp.intel.com>
 <20160410084852.GA5473@tyrael>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20160410084852.GA5473@tyrael>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1431
Lines: 37

On Sun, Apr 10, 2016 at 11:48:52AM +0300, Giedrius Statkevičius wrote:
> On Sat, Apr 09, 2016 at 08:21:21PM -0700, Darren Hart wrote:
> > On Thu, Apr 07, 2016 at 11:20:01PM +0300, Giedrius Statkevičius wrote:
> > > `out' was assigned value but it was never used so remove it
> > > 
> > > Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
> > > ---
> > >  drivers/platform/x86/asus-laptop.c | 3 ---
> > >  1 file changed, 3 deletions(-)
> > > 
> > > diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> > > index d86d42e..39ddcee 100644
> > > --- a/drivers/platform/x86/asus-laptop.c
> > > +++ b/drivers/platform/x86/asus-laptop.c
> > > @@ -946,11 +946,8 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
> > >  			      const char *method)
> > >  {
> > >  	int rv, value;
> > > -	int out = 0;
> > >  
> > >  	rv = parse_arg(buf, count, &value);
> > > -	if (rv > 0)
> > > -		out = value ? 1 : 0;
> > >  
> > >  	if (write_acpi_int(asus->handle, method, value))
> > 
> > out is indeed unused, however the rv > 0 condition is relevant as <=0 will pass
> > value uninitialized to write_acpi_int.
> That's indeed a problem. Somehow I missed that :( Should I make a v2 to include
> another patch that checks for rv < 0 or send it as an independent one?
> 

Please just rewrite this one to do the right thing as a v2.

-- 
Darren Hart
Intel Open Source Technology Center