MIME-Version: 1.0
In-Reply-To: <1460683781-22535-7-git-send-email-gustavo@padovan.org>
References: <1460683781-22535-1-git-send-email-gustavo@padovan.org>
	<1460683781-22535-7-git-send-email-gustavo@padovan.org>
Date: Thu, 14 Apr 2016 21:40:25 -0400
Message-ID: <CAF6AEGsZ3h87i-EzpSKyFcX71L1AvGdc04=ewr59oxp9rBtHHA@mail.gmail.com>
Subject: Re: [RFC 6/8] drm/fence: create DRM_MODE_ATOMIC_OUT_FENCE flag
From: Rob Clark <robdclark@gmail.com>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Daniel Stone <daniels@collabora.com>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        Riley Andrews <riandrews@android.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Greg Hackmann <ghackmann@google.com>,
        John Harrison <John.C.Harrison@intel.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sean Paul <seanpaul@google.com>,
        =?UTF-8?Q?St=C3=A9phane_Marchesin?= <marcheu@google.com>,
        Mauro Carvalho Chehab <m.chehab@samsung.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1455
Lines: 43

On Thu, Apr 14, 2016 at 9:29 PM, Gustavo Padovan <gustavo@padovan.org> wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> This flag tells drm_atomic_ioctl that we want to get a per-crtc out-fence
> fd back.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
>  include/uapi/drm/drm_mode.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index 7a7856e..39905cc 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -582,13 +582,15 @@ struct drm_mode_destroy_dumb {
>  #define DRM_MODE_ATOMIC_TEST_ONLY 0x0100
>  #define DRM_MODE_ATOMIC_NONBLOCK  0x0200
>  #define DRM_MODE_ATOMIC_ALLOW_MODESET 0x0400
> +#define DRM_MODE_ATOMIC_OUT_FENCE 0x0800
>
>  #define DRM_MODE_ATOMIC_FLAGS (\
>                 DRM_MODE_PAGE_FLIP_EVENT |\
>                 DRM_MODE_PAGE_FLIP_ASYNC |\
>                 DRM_MODE_ATOMIC_TEST_ONLY |\
>                 DRM_MODE_ATOMIC_NONBLOCK |\
> -               DRM_MODE_ATOMIC_ALLOW_MODESET)
> +               DRM_MODE_ATOMIC_ALLOW_MODESET |\
> +               DRM_MODE_ATOMIC_OUT_FENCE)

just to be pedantic / bisectable, perhaps this should be squashed in
to patch that actually starts using this flag?  Otherwise there is an
intermediate state in git where the flag is accepted but ignored..

BR,
-R


>  struct drm_mode_atomic {
>         __u32 flags;
> --
> 2.5.5
>