Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753172AbcDOCin (ORCPT ); Thu, 14 Apr 2016 22:38:43 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:46801 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752464AbcDOCil (ORCPT ); Thu, 14 Apr 2016 22:38:41 -0400 To: David Daney Cc: Jack Wang , lindar_liu@usish.com, "James E.J. Bottomley" , "Martin K. Petersen" , pmchba@pmcs.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, David Daney Subject: Re: [PATCH] pm80xx: Remove bogus address masking in pm8001_ioremap() From: "Martin K. Petersen" Organization: Oracle Corporation References: <1460582816-12703-1-git-send-email-ddaney.cavm@gmail.com> Date: Thu, 14 Apr 2016 22:38:16 -0400 In-Reply-To: <1460582816-12703-1-git-send-email-ddaney.cavm@gmail.com> (David Daney's message of "Wed, 13 Apr 2016 14:26:56 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 509 Lines: 14 >>>>> "David" == David Daney writes: David> It is unclear what the original intent of the masking was, but it David> is clearly incorrect to truncate a physical address before David> calling ioremap(). On systems where there are valid physical David> address bits above bit-31 (arm64 for example) the result is an David> eventual OOPs when initializing the driver. David> Remove the bogus code to fix it. Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering