Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbcDOHo1 (ORCPT ); Fri, 15 Apr 2016 03:44:27 -0400 Received: from mail-oi0-f47.google.com ([209.85.218.47]:35228 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751044AbcDOHoY (ORCPT ); Fri, 15 Apr 2016 03:44:24 -0400 MIME-Version: 1.0 In-Reply-To: <20160412152642.GA30211@ulmo.ba.sec> References: <1460473007-11535-1-git-send-email-ldewangan@nvidia.com> <1460473007-11535-2-git-send-email-ldewangan@nvidia.com> <20160412152642.GA30211@ulmo.ba.sec> Date: Fri, 15 Apr 2016 09:44:23 +0200 Message-ID: Subject: Re: [PATCH 1/7] soc/tegra: pmc: Use BIT macro for register field definition From: Linus Walleij To: Thierry Reding Cc: Laxman Dewangan , Stephen Warren , Alexandre Courbot , Rob Herring , Mark Rutland , Jon Hunter , "linux-tegra@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 633 Lines: 19 On Tue, Apr 12, 2016 at 5:26 PM, Thierry Reding wrote: > Does this matter at all? We use the explicit notation in quite a number > of places and it works great. I'd like to avoid needless churn unless > there is a very good reason to switch. I am softly enforcing in the GPIO subsystem because I think it's a great perceptual aid, I can skim code faster if this is used, easier for the brain to handle and thus simplifies maintenance. Others may disagree on its virtues. It is not a subjective opinion, but proving the point needs perceptual psychology research. Yours, Linus Walleij