Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753177AbcDOIAr (ORCPT ); Fri, 15 Apr 2016 04:00:47 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:43612 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751655AbcDOIAp (ORCPT ); Fri, 15 Apr 2016 04:00:45 -0400 Date: Fri, 15 Apr 2016 09:00:27 +0100 From: Mark Brown To: Linus Walleij Cc: Laxman Dewangan , Liam Girdwood , Arnd Bergmann , Olof Johansson , Stephen Warren , Thierry Reding , Alexandre Courbot , Rob Herring , Mark Rutland , Jon Hunter , "linux-tegra@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Ulf Hansson Message-ID: <20160415080027.GB3217@sirena.org.uk> References: <1460473007-11535-1-git-send-email-ldewangan@nvidia.com> <1460473007-11535-5-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rJwd6BRFiFCcLxzm" Content-Disposition: inline In-Reply-To: X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/7] soc/tegra: pmc: Add interface to set voltage of IO rails X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1697 Lines: 41 --rJwd6BRFiFCcLxzm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 15, 2016 at 09:54:34AM +0200, Linus Walleij wrote: > On Tue, Apr 12, 2016 at 4:56 PM, Laxman Dewangan wrote: > > NVIDIA Tegra210 supports some of the IO interface which can operate > > at 1.8V or 3.3V I/O rail voltage levels. SW needs to configure > > Tegra PMC register to set different voltage level of IO interface based > > on IO rail voltage from power supply i.e. power regulators. > Nobody seems to mention the elephant in the room: why is this > not using the regulator subsystem and instead using custom > code under drivers/soc? We have worried before about drivers/soc > becoming a dumping ground akin to drivers/misc The above changelog sounds like a regulator consumer not a regulator - based on what I'm reading there it's a driver that looks at the voltage being supplied to the device and sets some configuration in the device based on that voltage. This isn't that unusual for analogue circuits but it's definitely not something that's actually doing voltage regulation. --rJwd6BRFiFCcLxzm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXEJ+WAAoJECTWi3JdVIfQtwkIAIFCkWijD3mQ5M6Oyoz6iGX3 DMNt+ifpeQQ1ksBwfgmzvZuisUys21A4cdN1ROSvsJYu52TIYYPVjX+QydKeX5Ys Go0AmrvYwdV3SC+trfYVg1Kf+VSPwnTKSit5QrvFTZZ/dJUM0Eu6HYouLFq5gjpE 6NG5RHiTd34n5uWcGKEjEm1MZmHEdauegoZD6W6EWKQ0ycx3NampDMOr0UW4IFyL hTKjoVIns6uZhPTDdB875Wr0FwIyoB3xEtWUR8KxyC98SmhyeookPDV+kQuyl84n bzsMxiXC0Zu45rPwgj/+TiiyaPUWCxX7p4aiIZ/aEItAp1hFVXZuIpZGQGcafc8= =3lKE -----END PGP SIGNATURE----- --rJwd6BRFiFCcLxzm--