Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753551AbcDOI3Z (ORCPT ); Fri, 15 Apr 2016 04:29:25 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:36822 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752989AbcDOI3F (ORCPT ); Fri, 15 Apr 2016 04:29:05 -0400 MIME-Version: 1.0 In-Reply-To: <1459580269-64531-1-git-send-email-yingjoe.chen@mediatek.com> References: <1459580269-64531-1-git-send-email-yingjoe.chen@mediatek.com> Date: Fri, 15 Apr 2016 10:29:04 +0200 Message-ID: Subject: Re: [PATCH v2] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce From: Linus Walleij To: Yingjoe Chen Cc: Matthias Brugger , Hongzhou Yang , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , "linux-kernel@vger.kernel.org" , srv_heupstream@mediatek.com, Daniel Kurtz Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 706 Lines: 22 On Sat, Apr 2, 2016 at 8:57 AM, Yingjoe Chen wrote: > The debounce time unit for gpio_chip.set_debounce is us but > mtk_gpio_set_debounce regard it as ms. > Fix this by correct debounce time array dbnc_arr so it can find correct > debounce setting. Debounce time for first debounce setting is 500us, > correct this as well. > > While I'm at it, also change the debounce time array name to > "debounce_time" for readability. > > Signed-off-by: Yingjoe Chen > --- > This was based on v4.6-rc1 > Change since v1: > - Improve commit message. > - Change dbnc_arr name to debounce_time Patch applied to fixes and tagged for stable. Yours, Linus Walleij