Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751972AbcDOKgf (ORCPT ); Fri, 15 Apr 2016 06:36:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42287 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751883AbcDOKgd (ORCPT ); Fri, 15 Apr 2016 06:36:33 -0400 From: Denys Vlasenko To: Himanshu Madhani Cc: Denys Vlasenko , James Bottomley , qla2xxx-upstream@qlogic.com, Josh Poimboeuf , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646 Date: Fri, 15 Apr 2016 12:36:23 +0200 Message-Id: <1460716583-15673-1-git-send-email-dvlasenk@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 35 More info here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 Signed-off-by: Denys Vlasenko CC: Himanshu Madhani CC: James Bottomley CC: qla2xxx-upstream@qlogic.com CC: Josh Poimboeuf CC: linux-scsi@vger.kernel.org CC: linux-kernel@vger.kernel.org --- drivers/scsi/qla2xxx/qla_attr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index 4dc06a13..2dd9c72 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -2003,9 +2003,14 @@ static void qla2x00_get_host_fabric_name(struct Scsi_Host *shost) { scsi_qla_host_t *vha = shost_priv(shost); + /* + * This can trigger gcc 4.9/5.3 bug. + * See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 uint8_t node_name[WWN_SIZE] = { 0xFF, 0xFF, 0xFF, 0xFF, \ 0xFF, 0xFF, 0xFF, 0xFF}; u64 fabric_name = wwn_to_u64(node_name); + */ + u64 fabric_name = (u64)(s64)-1; /* the same as above */ if (vha->device_flags & SWITCH_FOUND) fabric_name = wwn_to_u64(vha->fabric_node_name); -- 1.8.1.4