Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753338AbcDOKlU (ORCPT ); Fri, 15 Apr 2016 06:41:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42941 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752194AbcDOKlP (ORCPT ); Fri, 15 Apr 2016 06:41:15 -0400 Date: Fri, 15 Apr 2016 12:41:08 +0200 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com, He Kuang , Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Zefan Li Subject: Re: [PATCH 02/10] perf tools: Add perf_data_file__switch() helper Message-ID: <20160415104108.GB2970@krava> References: <1460535673-159866-1-git-send-email-wangnan0@huawei.com> <1460535673-159866-3-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460535673-159866-3-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1326 Lines: 37 On Wed, Apr 13, 2016 at 08:21:05AM +0000, Wang Nan wrote: > perf_data_file__switch() closes current output file, renames it, then > open a new one to continue recording. It will be used by perf record > to split output into multiple perf.data files. > > Signed-off-by: Wang Nan > Signed-off-by: He Kuang > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Masami Hiramatsu > Cc: Namhyung Kim > Cc: Zefan Li > Cc: pi3orama@163.com > --- > tools/perf/util/data.c | 41 +++++++++++++++++++++++++++++++++++++++++ > tools/perf/util/data.h | 11 ++++++++++- > 2 files changed, 51 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c > index 1921942..be835161 100644 > --- a/tools/perf/util/data.c > +++ b/tools/perf/util/data.c > @@ -136,3 +136,44 @@ ssize_t perf_data_file__write(struct perf_data_file *file, > { > return writen(file->fd, buf, size); > } > + > +int perf_data_file__switch(struct perf_data_file *file, > + const char *postfix, > + size_t pos, bool at_exit) could you please rename at_exit to reopen I guess you follow the record object's at_exit naming, but 'reopen' seems more clear to me jirka