Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753331AbcDOK6Z (ORCPT ); Fri, 15 Apr 2016 06:58:25 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:32894 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbcDOK6T (ORCPT ); Fri, 15 Apr 2016 06:58:19 -0400 Subject: Re: [PATCH v6 07/12] usb: otg: add OTG/dual-role core To: Yoshihiro Shimoda , "stern@rowland.harvard.edu" , "balbi@kernel.org" , "gregkh@linuxfoundation.org" , "peter.chen@freescale.com" References: <1459865117-7032-1-git-send-email-rogerq@ti.com> <1459865117-7032-8-git-send-email-rogerq@ti.com> <57064850.3060405@ti.com> <570B8268.6090700@ti.com> <570F7827.8050707@ti.com> <570F7FB3.2040807@ti.com> CC: "dan.j.williams@intel.com" , "jun.li@freescale.com" , "mathias.nyman@linux.intel.com" , "tony@atomide.com" , "Joao.Pinto@synopsys.com" , "abrestic@chromium.org" , "r.baldyga@samsung.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" From: Roger Quadros Message-ID: <5710C928.2020704@ti.com> Date: Fri, 15 Apr 2016 13:57:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 41 On 15/04/16 12:59, Yoshihiro Shimoda wrote: > Hi, > >> From: Roger Quadros >> Sent: Thursday, April 14, 2016 8:32 PM >> >> On 14/04/16 14:15, Yoshihiro Shimoda wrote: >>> Hi, >>> > < snip > >>>>> @@ -865,7 +867,8 @@ int usb_otg_register_hcd(struct usb_hcd *hcd, unsigned int irqnum, >>>>> * we're ready only if we have shared HCD >>>>> * or we don't need shared HCD. >>>>> */ >>>>> - if (otg->shared_hcd.hcd || !otg->primary_hcd.hcd->shared_hcd) { >>>>> + if (otg->shared_hcd.hcd || (!otg->caps->needs_companion && >>>>> + !otg->primary_hcd.hcd->shared_hcd)) { >>>>> otg->host = hcd_to_bus(hcd); >>>>> /* FIXME: set bus->otg_port if this is true OTG port with HNP */ >>>>> >>>> >>>> These changes look good to me. Thanks. >>> >>> Thank you for the comment. >>> If we change the "needs_companion" place to the otg_config, >>> do we need to add a flag into the otg, instead of otg->caps? >> >> Yes we can add a flag in struct usb_otg. > > Thank you for the comment. > > I made a fixed patch. > So, should I send this patch to ML after you sent v7 patches? > Or, would you apply this patch before you send v7 patches? > Thanks for working on this and testing the series. I will pick your patch as part of v7. cheers, -roger