Subject: Re: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc
To: =?UTF-8?Q?Heiko_St=c3=bcbner?= <heiko@sntech.de>,
        Wolfram Sang <wsa@the-dreams.de>
References: <1458147438-62387-1-git-send-email-david.wu@rock-chips.com>
 <1458147438-62387-3-git-send-email-david.wu@rock-chips.com>
 <20160414184848.GB2338@katana> <2530516.Iqqf6HUmr5@diego>
Cc: dianders@chromium.org, andy.shevchenko@gmail.com, huangtao@rock-chips.com,
        hl@rock-chips.com, xjq@rock-chips.com, zyw@rock-chips.com,
        cf@rock-chips.com, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, David Wu <wdc@rock-chips.com>
From: "David.Wu" <david.wu@rock-chips.com>
Message-ID: <5710DA93.1020708@rock-chips.com>
Date: Fri, 15 Apr 2016 20:12:03 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <2530516.Iqqf6HUmr5@diego>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 693
Lines: 22

Hi Heiko,

在 2016/4/15 15:31, Heiko Stübner 写道:
> David,
>
> Am Donnerstag, 14. April 2016, 20:48:48 schrieb Wolfram Sang:
>>> + - input-clk-rate : frequency rate of function clock used(in Hz). If
>>> omitted, +	the default clock rate is used. It is just used at rk3399 soc.
>> Why is this needed? Why don't we simply use the default or calculate the
>> best value somehow?
> if you need to _get_ the clock-rate, clk_get_rate is the abvious choice and if
> you need to _set_ some specific rate, I guess it should be done via the
> assigned-clocks mechanism in the devicetree - see veyron dts files that already
> do this for some other parts.

Okay, i will try it, thank you.

>
>
>
>