Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751881AbcDOMWk (ORCPT ); Fri, 15 Apr 2016 08:22:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37095 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbcDOMWi (ORCPT ); Fri, 15 Apr 2016 08:22:38 -0400 From: Kalle Valo To: Eliad Peller Cc: Joe Perches , LKML , "linux-wireless\@vger.kernel.org" , "open list\:NETWORKING DRIVERS" , Guy Mishol , Uri Mashiach , Johannes Berg Subject: Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style References: <87shz85gkq.fsf@purkki.adurom.net> <1459373791.25110.132.camel@perches.com> <87y48z3xkz.fsf@purkki.adurom.net> <1459411668.1744.6.camel@perches.com> Date: Fri, 15 Apr 2016 15:22:28 +0300 In-Reply-To: (Eliad Peller's message of "Thu, 31 Mar 2016 11:59:39 +0300") Message-ID: <87a8kvqcxn.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1911 Lines: 45 Eliad Peller writes: > On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches wrote: >> On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: >>> Joe Perches writes: >>> > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: >>> > > Joe Perches writes: >>> > > > >>> > > > Using the normal kernel logging mechanisms makes this code >>> > > > a bit more like other wireless drivers. >>> > > Personally I don't see the point but I don't have any strong opinions. A >>> > > bigger problem is that TI drivers are not really in active development >>> > > and that's I'm not thrilled to take big patches like this for dormant >>> > > drivers. >>> > Not very dormant. >>> > >>> > 35 patches in the last year, most of them adding functionality. >>> Oh, I didn't realise it had that many patches. But the driver is >>> orphaned and doesn't have a maintainer so could I then have an ack from >>> one of the active contributors that this ok? >> >> Fine by me. >> >> $ ./scripts/get_maintainer.pl -f --git drivers/net/wireless/ti/ >> >> Kalle Valo (maintainer:NETWORKING DRIVERS (WIRELESS),commit_signer:27/35=77%) >> Eliad Peller (commit_signer:9/35=26%,authored:7/35=20%) >> Guy Mishol (commit_signer:6/35=17%,authored:5/35=14%) >> Johannes Berg (commit_signer:6/35=17%,authored:3/35=9%) >> Uri Mashiach (commit_signer:4/35=11%,authored:4/35=11%) >> >> For those people now added to the cc list, >> here's the original patch thread: >> >> https://lkml.org/lkml/2016/3/7/1099 > > I don't have a strong opinion here either. > (I do like the trailing newline being added automatically, but that's > hardly an issue...) Ok, I didn't get any objections so I'm planning to this set. If someone thinks this is a bad idea speak up now. -- Kalle Valo