Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbcDONIn (ORCPT ); Fri, 15 Apr 2016 09:08:43 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34105 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbcDONIm (ORCPT ); Fri, 15 Apr 2016 09:08:42 -0400 Date: Fri, 15 Apr 2016 15:08:40 +0200 From: Michal Hocko To: Mikulas Patocka Cc: linux-mm@kvack.org, Andrew Morton , LKML , Shaohua Li Subject: Re: [PATCH 17/19] dm: get rid of superfluous gfp flags Message-ID: <20160415130839.GJ32377@dhcp22.suse.cz> References: <1460372892-8157-1-git-send-email-mhocko@kernel.org> <1460372892-8157-18-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 809 Lines: 22 On Fri 15-04-16 08:29:28, Mikulas Patocka wrote: > > > On Mon, 11 Apr 2016, Michal Hocko wrote: > > > From: Michal Hocko > > > > copy_params seems to be little bit confused about which allocation flags > > to use. It enforces GFP_NOIO even though it uses > > memalloc_noio_{save,restore} which enforces GFP_NOIO at the page > > memalloc_noio_{save,restore} is used because __vmalloc is flawed and > doesn't respect GFP_NOIO properly (it doesn't use gfp flags when > allocating pagetables). Yes and there are no plans to change __vmalloc to properly propagate gfp flags through the whole call chain and that is why we have memalloc_noio thingy. If that ever changes later the GFP_NOIO can be added in favor of memalloc_noio API. Both are clearly redundant. -- Michal Hocko SUSE Labs